add node version requirement for bcrypt library #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`yarn install` with node 12 will throw error See [bcrypt library version compatibility table](https://github.com/kelektiv/node.bcrypt.js#version-compatibility)
|
@hirsch88 |
|
I think the better approach would be to just make bcrypt compatible with v12 by upgrading bcrypt from 3.0.1 to 3.0.6. Doing that will allow everything to install properly. Sqlite will need to be updated to 4.2 also. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yarn installwith node 12 will throw errorSee bcrypt library version compatibility table