Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sep_report and sep_config not sufficient for working with non-UK/US configured machines? #1048

Closed
vincentvanhees opened this issue Feb 18, 2024 · 0 comments · Fixed by #1049
Closed

sep_report and sep_config not sufficient for working with non-UK/US configured machines? #1048

vincentvanhees opened this issue Feb 18, 2024 · 0 comments · Fixed by #1049
Assignees
@vincentvanhees

Comments

@vincentvanhees
Copy link
Member

Arguments sep_report and sep_config were implemented a while ago by @jhmigueles to allow for saving csv reports with alternative column separator values to ease use in non UK/US configured R installations.

I tried it last week on a Dutch configured computer. Although columns seem to be split correctly the values were off, which makes me wonder whether it is also critical that we specify the dec argument every time the csv file is safe or loaded, e.g. in functions extract_params and g.plot5.
@vincentvanhees vincentvanhees self-assigned this Feb 19, 2024
vincentvanhees added a commit that referenced this issue Feb 19, 2024
@vincentvanhees
add new parameters dec_reports and dec_config, fixes #1048
664e726
vincentvanhees added a commit that referenced this issue Feb 19, 2024
@vincentvanhees
add check that sep and dec are not equal #1048
2214399
@vincentvanhees vincentvanhees mentioned this issue Feb 19, 2024
Merged
5 tasks
vincentvanhees added a commit that referenced this issue Feb 19, 2024
@vincentvanhees
add new parameters dec_reports and dec_config, fixes #1048
f87e8b4
vincentvanhees added a commit that referenced this issue Feb 19, 2024
@vincentvanhees
add check that sep and dec are not equal #1048
862e871
vincentvanhees added a commit that referenced this issue Feb 21, 2024
@vincentvanhees
Export namespace and LC_TIME to parallel process
16b97f0 
This is part of addressing #1048 and complements PR #1049 but I am adding this in PR #1028 because of all the changes to part 6 in this PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vincentvanhees vincentvanhees

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make GGIR run easier on machines not configured for UK/US wadpac/GGIR
1 participant
@vincentvanhees