setup.sh script attempts to copy file in bakerydemo which doesn't exist anymore

[floels]

Hi,

When running the setup.sh script locally to set up my local Wagtail development environment, I got the following error in the terminal:

Creating local settings file cp: bakerydemo/bakerydemo/settings/local.py.docker-compose-example: No such file or directory

The error comes from the following line of the script:

docker-wagtail-develop/setup.sh

Line 40 in 9ee7679

cp bakerydemo/bakerydemo/settings/local.py.docker-compose-example bakerydemo/bakerydemo/settings/local.py

and indeed bakerydemo/settings/local.py.docker-compose-example doesn't exist anymore in bakerydemo. It was removed in this PR merged three weeks ago.

I guess the correct command in setup.sh would be:

cp bakerydemo/bakerydemo/settings/local.py.example bakerydemo/bakerydemo/settings/local.py

I can make a PR to change it if you confirm.

[saevarom]

Thanks @floels

I think that just referencing local.py is not sufficient, we need the lines from the old docker compose example file so that the project uses the env variable DATABASE_URL to connect to the db.

import dj_database_url

# Override settings here
db_from_env = dj_database_url.config(conn_max_age=500)
DATABASES['default'].update(db_from_env)

But I think we can just create our own local settings example file to maintain in this repository. If you want to create a PR then go for it.

[floels]

Hi @saevarom,

Thanks for the quick reply. Ok so just to make sure I understand, we would:

1. create a bakerydemo-settings-local.example file with the following content:

import dj_database_url

# Override settings here
db_from_env = dj_database_url.config(conn_max_age=500)
DATABASES['default'].update(db_from_env)

at the root of this docker-wagtail-develop repo,

2. replace:

docker-wagtail-develop/setup.sh

Line 40 in 9ee7679

cp bakerydemo/bakerydemo/settings/local.py.docker-compose-example bakerydemo/bakerydemo/settings/local.py

in setup.sh with:

cp bakerydemo-settings-local.example bakerydemo/bakerydemo/settings/local.py?

[saevarom]

Yes, almost, but the full contents of the bakerydemo-settings-local.example would probably need to be:

from bakerydemo.settings.dev import *   # noqa
import dj_database_url

# Override settings here
db_from_env = dj_database_url.config(conn_max_age=500)
DATABASES['default'].update(db_from_env)

I omitted the first line to only show what the difference between the files was