Add bakerydemo local settings example file and fix setup script accordingly (#54) #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based on your tests and the CI check I will merge this. Thanks @floels ! |
|
Fixes #54 |
floels
deleted the
fix/54-add-bakery-demo-local-settings-example-fix-and-fix-setup-script
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in issue #54, the goal of this PR is to fix the
setup.shscript, which currently attempts to copy a file that does not exist anymore (due to this PR in thebakerydemorepo).We create an example file with the proper content at the root of the repo and update the
setup.shscript accordingly.To test that this worked properly, I ran the modified version of the
setup.shscript and I was able to see that the right file was created in thebakerydemo/bakerydemo/settingsfolder. The error message mentioned in #54 didn't appear anymore. I followed the rest of the regular setup instructions and I was able to boot an instance ofbakerydemo.