cqueues.h: correctly declare a variable #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise it gets a definition in every *.c file it gets included into. I'm not sure why these errors never caused problems (AFAIK) until recent Fedora Rawhide. https://kojipkgs.fedoraproject.org//work/tasks/420/41320420/build.log
|
On a different distro using gcc10 isn't sufficient to trigger this error (or even a warning), so the practical consequences of missing |
|
ping @wahern |
|
I meant, ping @daurnimator :-) |
|
I think this is correct but I'm not 100% sure. Would love for you @wahern to confirm... |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise it gets a definition in every *.c file it gets included into.
I'm not sure why these errors never caused problems (AFAIK) until recent Fedora Rawhide.
https://kojipkgs.fedoraproject.org//work/tasks/420/41320420/build.log