-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: unify runtime API signatures #129
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 21, 2019
| return function (message) { | ||
| console.warn('Method Log.' + oldName + ' has been deprecated. Please use Log.' + newName); | ||
| return fn(message); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing semicolon.
| return function (eventName, eventData) { | ||
| console.warn('Method events.' + oldName + ' has been deprecated. Please use Events.' + newName); | ||
| return fn(eventName, eventData); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing semicolon.
| @@ -259,7 +259,7 @@ | |||
| try { | |||
| parsedData = JSON.parse(data); | |||
| } catch (e) { | |||
| wails.log.error("Invalid JSON data sent to notify. Event name = " + eventName) | |||
| wails.Log.Error("Invalid JSON data sent to notify. Event name = " + eventName) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing semicolon.
Hard-Coded Secrets (4)Line 8 in 36e575e
Line 9 in 36e575e
Line 8 in 36e575e
Line 9 in 36e575e
More info on how to fix Hard-Coded Secrets in General. Happy with the results? Give your feedback. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.