-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement custom protocol association support #3000
Conversation
…feature/open-files
…feature/open-files
@leaanthony @stffabi please take a look on this too 😊 This feature will be really handy in case when devs have web app and want to open desktop app builded with Wails in some cases |
@leaanthony sorry for ping you, just want to check if you saw this PR :) |
Sorry, I've not been feeling too good so haven't been in the right headspace for this. Others can take a look in the meantime |
@leaanthony @stffabi |
I'm good with this PR. Thanks so much for spending the time doing it and your patience. I'll just give @stffabi a couple of days to look at it and we'll get it in. Thanks again 🙏 |
Would this be available in a 2.x release when it's merged? 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Thanks so much for this awesome PR @APshenkin and taking the time to do this 🙏 .
Yes, this PR is targeting v2. |
Thanks again @APshenkin! You're filling my v3 backlog by stealth 😅 |
@leaanthony I'm really excited about Wails (and its V3 as well) and planing to do some app with it 🙂 Maybe will introduce some more PRs if will need some features in Wails more 😊 |
Hello! @APshenkin
I have replaced the local wails. Getting this error while building the project
|
Hi folks, I'm unable to get this to work on a mac. Tried open("customapp://localhost:port/path") like in the vid but it complains that there is no registered scheme handler for customapp://. Is there any plan to update the documentations on how to achieve this? |
@byteams - thanks for reporting this. Perhaps it's best to open a new issue rather than an old PR. Might also be worth mentioning @APshenkin to see if he's still around. |
@leaanthony gotcha ok. Let me create a new issue this weekend. Thanks btw for this awesome project. |
Description
Implements custom protocol association support for macOS/Windows. This will allow connect web apps with desktop apps builded with Wails
Users can specify list of custom protocols in
wails.json
config with following paramsFew comments regarding implementation
MacOS: Darwin handle opening file by raising
handleGetURLEvent
event. Callback is added for app configuration to handle this correctly.Windows: On Windows protocols association is done via NSIS installer. So apps should be distributed with it to have this feature.
When custom protocol URL is opened, Windows launches new instance of the app and pass url as argument. So apps developers should parse args and handle situation properly.
Linux: To setup association changes on client system should be done. As wails doesn't support bundling for linux now, nothing was added in this PR for it, but in test repo that is provided below you can see how this can be done using nfmp. Also this is added in guides.
You can see how it works here.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Test repo is available here https://github.com/APshenkin/wails-open-file/tree/feature/deeplinks
PR should be fetched and replace in go.mod should be adjusted
Test Configuration
Checklist:
website/src/pages/changelog.mdx
with details of this PR