refactor(store): HistoryQuery.direction #2263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from f8677e4 |
2 tasks
Ivansete-status
requested changes
Dec 1, 2023
There was a problem hiding this comment.
Thanks for this PR!
It looks great! Besides, I think it would be a bit better if we could use the following type when we refer to a "pagination direction", if that's feasible of course
Line 44 in 103d398
Ivansete-status
approved these changes
Dec 11, 2023
AlejandroCabeza
force-pushed
the
history-query-ascending
branch
from
61d9e29 to
4b32cf4
Compare
AlejandroCabeza
requested review from
NagyZoltanPeter
and removed request for
alrevuelta
…ons: Should use the same value.
AlejandroCabeza
force-pushed
the
history-query-ascending
branch
from
1ca30ae to
01214b1
Compare
NagyZoltanPeter
approved these changes
Dec 19, 2023
Ivansete-status
pushed a commit
that referenced
this pull request
Jan 9, 2024
* Fix issue with default history query ascending value in serde operations: Should use the same value. * Update direction types to PagingDirection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update
HistoryQuery.ascending(and related) references todirectionso they are consistent with RFC naming. Also, fix a default value issue with it.Changes
ascendingreferences todirectionHistoryQuery.direction