Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Citeseq celltypes #69

Closed
wants to merge 5 commits into from
Closed

Conversation

drighelli
Copy link
Collaborator

@drighelli drighelli commented May 23, 2023

adding code, metadata, script, new functions and ontomap for the cord_blood identified celltypes.

@drighelli
Copy link
Collaborator Author

drighelli commented May 23, 2023

There was a conflict that has been resolved by adding the new code in the .cord_blood function.
It solves a bug where the cd could be also an empty object.

@drighelli drighelli requested a review from LiNk-NY May 23, 2023 13:36
Copy link
Contributor

@LiNk-NY LiNk-NY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. I will move the metadata entry to the end of the metadata.csv.

@@ -40,6 +40,7 @@ mouse_visual_cortex,seqFISH_Coordinates.rda,SingleCellMultiModal/mouse_visual_co
mouse_visual_cortex,seqFISH_Counts.rda,SingleCellMultiModal/mouse_visual_cortex/v2.0.0/seqFISH_Counts.rda,Rda,matrix,Dario Righelli <dario.righelli@gmail.com>,"Dept. of Molecular Genetics, Allen Institute for Brain Science, United States",NA,10090,Mus musculus,2.0.0,https://www.dropbox.com/sh/avj4nrd4la5i88u/AACafWwBbE-xsLvOGDwRZDpYa?dl=0,TXT,NA,3.12,seqFISH_Counts data specific to the MOUSE_VISUAL_CORTEX project,seqFISH_Counts
mouse_visual_cortex,seqFISH_Labels.rda,SingleCellMultiModal/mouse_visual_cortex/v2.0.0/seqFISH_Labels.rda,Rda,data.frame,Dario Righelli <dario.righelli@gmail.com>,"Dept. of Molecular Genetics, Allen Institute for Brain Science, United States",NA,10090,Mus musculus,2.0.0,https://www.dropbox.com/sh/avj4nrd4la5i88u/AACafWwBbE-xsLvOGDwRZDpYa?dl=0,TXT,NA,3.12,seqFISH_Labels data specific to the MOUSE_VISUAL_CORTEX project,seqFISH_Labels
cord_blood,scADT_Counts.rda,SingleCellMultiModal/cord_blood/v1.0.0/scADT_Counts.rda,Rda,matrix,Dario Righelli <dario.righelli@gmail.com>,"Innovation Lab, New York Genome Center, New York, United States",NA,9606,Homo sapiens,1.0.0,https://www.ncbi.nlm.nih.gov/geo/query/acc.cgi?acc=GSE100866,TXT,NA,3.12,scADT_Counts data specific to the CORD_BLOOD project,scADT_Counts
cord_blood,scADT_clrCounts.rda,SingleCellMultiModal/cord_blood/v1.0.0/scADT_clrCounts.rda,Rda,matrix,Dario Righelli <dario.righelli@gmail.com>,"Innovation Lab, New York Genome Center, New York, United States",NA,9606,Homo sapiens,1.0.0,https://www.ncbi.nlm.nih.gov/geo/query/acc.cgi?acc=GSE100866,TXT,NA,3.12,scADT_clrCounts data specific to the CORD_BLOOD project,scADT_clrCounts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(for future reference) please add to the bottom of the file

@LiNk-NY
Copy link
Contributor

LiNk-NY commented May 23, 2023

Please try to avoid merge commits with devel and instead checkout from devel and commit your changes on top of the branch.
That is:

git checkout -b new_branch origin/devel
git commit # etc.
git push origin new_branch

@LiNk-NY
Copy link
Contributor

LiNk-NY commented May 23, 2023

Merged with rebase to clean up the merge commit. Thanks!

@LiNk-NY LiNk-NY closed this May 23, 2023
@LiNk-NY
Copy link
Contributor

LiNk-NY commented May 23, 2023

@drighelli
Note. Make sure that the BiocVersion matches the current devel version 3.18 in the metadata.csv.

I have updated this.

@drighelli
Copy link
Collaborator Author

ok, sorry for the errors!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants