Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment line count even if line is ignored #6

Closed
wants to merge 2 commits into from

Conversation

JeanMertz
Copy link
Contributor

@JeanMertz JeanMertz commented Jun 22, 2018

If a line was configured to be skipped, the line count was not incremented, resulting in the wrong offending lines to be reported back to the user.

@codecov-io
Copy link

Codecov Report

Merging #6 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #6   +/-   ##
=======================================
  Coverage   72.72%   72.72%           
=======================================
  Files           1        1           
  Lines          55       55           
=======================================
  Hits           40       40           
  Misses         10       10           
  Partials        5        5
Impacted Files Coverage Δ
lll.go 72.72% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b13b3f...60bf7b3. Read the comment docs.

@JeanMertz
Copy link
Contributor Author

The remaining build errors are related to Go 1.5. I haven't dug into the issues (not sure if it's worth it for such an old Go version), but here's the output:

$ go get -t -v ./...
github.com/alexflint/go-arg (download)
github.com/alexflint/go-scalar (download)
github.com/walle/lll
github.com/alexflint/go-scalar
github.com/alexflint/go-arg
github.com/walle/lll/vendor/github.com/alexflint/go-arg
# github.com/alexflint/go-arg
../../alexflint/go-arg/parse.go:157: field.Tag.Lookup undefined (type reflect.StructTag has no field or method Lookup)
The command "eval go get -t -v ./... " failed. Retrying, 2 of 3.
github.com/alexflint/go-arg
# github.com/alexflint/go-arg
../../alexflint/go-arg/parse.go:157: field.Tag.Lookup undefined (type reflect.StructTag has no field or method Lookup)
The command "eval go get -t -v ./... " failed. Retrying, 3 of 3.
github.com/alexflint/go-arg
# github.com/alexflint/go-arg
../../alexflint/go-arg/parse.go:157: field.Tag.Lookup undefined (type reflect.StructTag has no field or method Lookup)
The command "eval go get -t -v ./... " failed 3 times.

JeanMertz added a commit to JeanMertz/lll that referenced this pull request Jun 22, 2018
@walle
Copy link
Owner

walle commented Aug 16, 2019

I'm sorry for taking this long to get to the PR, but it is finally in the
project as part of the v1.0.0 release.

Thank you for you contribution!

@walle walle closed this Aug 16, 2019
@walle walle mentioned this pull request Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants