Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.5.0 #92

Merged
merged 25 commits into from
Feb 2, 2024
Merged

Release 1.5.0 #92

merged 25 commits into from
Feb 2, 2024

Conversation

BalbinaK
Copy link
Contributor

@BalbinaK BalbinaK commented Feb 2, 2024

No description provided.

BalbinaK and others added 24 commits December 13, 2023 12:56
Enable crowdin-sync workflow to be triggered manually
* chore(crowdin-sync): assign BalbinaK as Crowdin PR reviewer

* chore: add comments to event triggers
* fix locale detection for icons

* Add a fallback with detection

* Change wording
## [1.4.1-next.1](v1.4.0...v1.4.1-next.1) (2024-01-11)

### Bug Fixes

* locale detection for icons ([#81](#81)) ([f97d09f](f97d09f))
* chore(deps): update all dependencies (non-major)

* chore: fix nunjucks call after updating to 0.2.0

* chore(deps): bump versions in package.json to update lockfile

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: BalbinaK <balbuhhha@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* chore: new translations from Crowdin

* chore: new translations from Crowdin

---------

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
## [1.4.1-next.2](v1.4.1-next.1...v1.4.1-next.2) (2024-01-23)

### Bug Fixes

* update oikotie market icons ([#83](#83)) ([d4bad16](d4bad16))
* feat: add geometric-shapes market icon

* Add missing 16-pixel icons
# [1.5.0-next.1](v1.4.1-next.2...v1.5.0-next.1) (2024-01-24)

### Features

* add missing 16px icons and a geometric-shapes icon ([#84](#84)) ([c22fd1b](c22fd1b))
* chore: new translations from Crowdin

* chore: new translations from Crowdin

---------

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
# [1.5.0-next.2](v1.5.0-next.1...v1.5.0-next.2) (2024-01-29)

### Features

* add missing icons ([#88](#88)) ([f5db3ac](f5db3ac))
# [1.5.0-next.3](v1.5.0-next.2...v1.5.0-next.3) (2024-02-01)

### Bug Fixes

* update strings for logout, picture-stack and organize ([#90](#90)) ([f381be3](f381be3))
* chore(scripts): print names of icon files that have invalid width/height value

When we copy over svgs from Figma, it sometimes happens that those files have invalid height/width
applied to svg element. By printing a list of invalid icons, we are increasing our chances of
spotting those tiny errors.

* feat: update remaining icons and add missing 16px sizes
# [1.5.0-next.4](v1.5.0-next.3...v1.5.0-next.4) (2024-02-02)

### Features

* add 16px icons and update all svgs ([#91](#91)) ([a5f5794](a5f5794))
* chore: new translations from Crowdin

* chore: new translations from Crowdin

---------

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
* chore(deps): update all dependencies (non-major)

* chore: update lockfile and remove ^ from versions in package.json

This might help renovate update versions automatically in package.json next time.

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: BalbinaK <balbuhhha@gmail.com>
@BalbinaK BalbinaK requested a review from a team February 2, 2024 08:10
Copy link
Contributor

@felicia-haggqvist felicia-haggqvist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get this warning in the console when building the icons for react (works fine with building vue and elements icons):

Icons with invalid width or height attribute:
warranty-32.js
triangle-24.js
triangle-16.js
torget-headset-24.js
paw-24.js
honk-42.js
favorite-16.js

However it still builds these icons and I tried to use one of them in the react-repo, which worked fine without any issues. :)

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
@BalbinaK
Copy link
Contributor Author

BalbinaK commented Feb 2, 2024

I get this warning in the console when building the icons for react (works fine with building vue and elements icons):

Icons with invalid width or height attribute:
warranty-32.js
triangle-24.js
triangle-16.js
torget-headset-24.js
paw-24.js
honk-42.js
favorite-16.js

However it still builds these icons and I tried to use one of them in the react-repo, which worked fine without any issues. :)

These icons are fixed in #86, so the warning will be gone there 😊

@BalbinaK BalbinaK merged commit 9030bff into main Feb 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants