fix: a11y issues for attention component #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imprashast
reviewed
Oct 11, 2023
| zIndex: 1, | ||
| // border alignment is off by a fraction of a pixel, this fixes it | ||
| [`margin${arrowDirectionClassname(arrowDirection)}`]: '-0.5px', | ||
| [`margin${arrowDirectionClassname(arrowDirection)}`]: "-0.5px", |
There was a problem hiding this comment.
Did we change the prettier config or something?
There was a problem hiding this comment.
Could be from my prettier-extension! Do we have a prettier config? I have the "Prettier - Code formatter" installed
There was a problem hiding this comment.
I don't see one. But we should probably have one in all our repo's. I'll make a task :)
imprashast
approved these changes
Oct 11, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Oct 11, 2023
## [1.1.1-next.4](v1.1.1-next.3...v1.1.1-next.4) (2023-10-11) ### Bug Fixes * a11y issues for attention component ([#123](#123)) ([0588564](0588564))
BalbinaK
reviewed
Oct 11, 2023
| ariaLabel?: string; | ||
|
|
||
| /** | ||
| * Sets the aria-role attribute for the Attention component |
There was a problem hiding this comment.
Should probably be role attribute :)
There was a problem hiding this comment.
Whoops! I can create a mini-pr to fix that: https://github.com/warp-ds/react/pull/125/files
github-actions bot
pushed a commit
that referenced
this pull request
Oct 23, 2023
## [1.1.1](v1.1.0...v1.1.1) (2023-10-23) ### Bug Fixes * a11y fixes for button link and link as buttons ([#132](#132)) ([47c6bd7](47c6bd7)) * a11y issues for attention component ([#123](#123)) ([0588564](0588564)) * add leading slash to crowdin path ([#98](#98)) ([472d456](472d456)) * add source locale to lingui config ([#103](#103)) ([aaf3dc0](aaf3dc0)) * anchor text alignment & icon translations ([#134](#134)) ([d682586](d682586)) * ay11 fixes for the Modal component and affected stories ([#128](#128)) ([a1fdf92](a1fdf92)) * **breadcrumbs.js:** Remove double Aria Label ([90d56a8](90d56a8)) * **breadcrumbs:** fixed double arialabel and removed area hidden from the seperators ([02f4eb2](02f4eb2)) * connect helptext to text area ([#131](#131)) ([a7a7643](a7a7643)) * improve destination config for crowdin ([#112](#112)) ([7bd543a](7bd543a)) * only sync locales on next branch for now ([#99](#99)) ([f068199](f068199)) * replace inline svgs with warp icons ([#95](#95)) ([17f5b05](17f5b05))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a11y issues raised in WARP-320 :
ESCto close the tooltip: