refactor: replace inline svgs with warp icons #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or affix to use @warp-ds' icons
…tories.tsx" in tsconfig.json
BalbinaK
reviewed
Oct 12, 2023
package.json
Outdated
| "@warp-ds/uno": "^1.1.0", | ||
| "@warp-ds/icons":"1.1.0-next.10", |
There was a problem hiding this comment.
If you change that to 1.1.0-next.11 and install 1.1.1 of @warp-ds/css then I'm pretty sure we can merge this PR 🤞
There was a problem hiding this comment.
Updated the versions! 💃
imprashast
approved these changes
Oct 13, 2023
BalbinaK
approved these changes
Oct 13, 2023
felicia-haggqvist
deleted the
refactor/replace-inline-svgs-with-warp-icons
branch
github-actions bot
pushed a commit
that referenced
this pull request
Oct 13, 2023
## [1.1.1-next.5](v1.1.1-next.4...v1.1.1-next.5) (2023-10-13) ### Bug Fixes * replace inline svgs with warp icons ([#95](#95)) ([17f5b05](17f5b05))
github-actions bot
pushed a commit
that referenced
this pull request
Oct 23, 2023
## [1.1.1](v1.1.0...v1.1.1) (2023-10-23) ### Bug Fixes * a11y fixes for button link and link as buttons ([#132](#132)) ([47c6bd7](47c6bd7)) * a11y issues for attention component ([#123](#123)) ([0588564](0588564)) * add leading slash to crowdin path ([#98](#98)) ([472d456](472d456)) * add source locale to lingui config ([#103](#103)) ([aaf3dc0](aaf3dc0)) * anchor text alignment & icon translations ([#134](#134)) ([d682586](d682586)) * ay11 fixes for the Modal component and affected stories ([#128](#128)) ([a1fdf92](a1fdf92)) * **breadcrumbs.js:** Remove double Aria Label ([90d56a8](90d56a8)) * **breadcrumbs:** fixed double arialabel and removed area hidden from the seperators ([02f4eb2](02f4eb2)) * connect helptext to text area ([#131](#131)) ([a7a7643](a7a7643)) * improve destination config for crowdin ([#112](#112)) ([7bd543a](7bd543a)) * only sync locales on next branch for now ([#99](#99)) ([f068199](f068199)) * replace inline svgs with warp icons ([#95](#95)) ([17f5b05](17f5b05))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace inline-svg:s with the icons from @warp-ds/icons in order to ensure translations for the svg-title will be handled in the same way for all components that use these icons.