Fix Homebrew Installs: Zig 0.14, PCRE2 #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add complete PCRE2 10.42 source tree in src/pcre2/ - Includes all headers, source files, and build configuration - No functional changes, pure vendor import
- Delete src/pcre/ directory and all PCRE v1 files - No functional impact, just cleanup before PCRE2 migration
- Add thin regex wrapper and switch headers/types/flags - Support vendored PCRE2 with toggle; default to vendored - Produce wasm to zig-out/lib and adjust CI Windows artifact path - Restore missing Python/CI files and benchmarking script Notes: - Preserves behavior; all C tests (21/21) and Python tests (8/8) pass - CI release and wheels workflows tested across platforms
There was a problem hiding this comment.
Pull Request Overview
This PR migrates FastFEC from the deprecated PCRE v1 library to the modern PCRE2 v10.42 while adding Zig 0.14+ support. This resolves compatibility issues with Homebrew installations and end-of-life dependencies.
Key changes:
- Upgraded from PCRE v1 to PCRE2 v10.42
- Added Zig 0.14+ compatibility to the build system
- Created a thin compatibility wrapper to maintain API compatibility
Reviewed Changes
Copilot reviewed 54 out of 92 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/pcre2/pcre2_chartables.c | Updated character tables with PCRE2 structure and comments |
| src/pcre2/pcre2_auto_possess.c | New PCRE2 auto-possessification module |
| src/pcre2/pcre2.h | Main PCRE2 public header with comprehensive API |
| src/pcre2/config.h | PCRE2 build configuration file |
| src/pcre2/LICENCE | Updated PCRE2 license with current terms |
| src/pcre/ucp.h | Removed old PCRE v1 Unicode property header |
| src/pcre/pcreposix.h | Removed old PCRE v1 POSIX compatibility header |
| src/pcre/pcreposix.c | Removed old PCRE v1 POSIX compatibility implementation |
| src/pcre/pcredemo.c | Removed old PCRE v1 demonstration program |
| src/pcre/pcrecpparg.h | Removed old PCRE v1 C++ argument handling |
| src/pcre/pcrecpp_internal.h | Removed old PCRE v1 C++ internal definitions |
| src/pcre/pcrecpp.h | Removed old PCRE v1 C++ wrapper |
| src/pcre/pcre_version.c | Removed old PCRE v1 version reporting |
| src/pcre/pcre_tables.c | Removed old PCRE v1 character tables |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| /* This set of tables was written in the C locale. */ | ||
|
|
||
| /* The pcre2_ftables program (which is distributed with PCRE2) can be used |
There was a problem hiding this comment.
Corrected spelling of 'pcre2_ftables' to 'pcre2_dftables'.
Suggested change
| /* The pcre2_ftables program (which is distributed with PCRE2) can be used | |
| /* The pcre2_dftables program (which is distributed with PCRE2) can be used |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Click here to view only the non-vendored PCRE/PCRE2 changes.
Migrates FastFEC from end-of-life PCRE v1 to PCRE2 while adding Zig 0.14+ support and cleaning up the build system to fix Homebrew installs.
Resolves:
What Changed
src/pcre2/src/regex.handsrc/regex.cto maintain API compatibilitybuild.zigfor Zig 0.14+ with flexible PCRE2 linkingTest Steps