feat(*): Notifies on manifest deployment #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomastaylor312
force-pushed
the
feat/notify_manifests
branch
2 times, most recently
from
0b19d4d
to
bd15001
Compare
13 tasks
thomastaylor312
force-pushed
the
feat/notify_manifests
branch
from
bd15001
to
593a575
Compare
src/mirror/mod.rs
Outdated
| description: Some(format!("Durable wadm mirror consumer for {lattice_id}")), | ||
| ack_policy: async_nats::jetstream::consumer::AckPolicy::Explicit, | ||
| // These should be real quick to ack | ||
| ack_wait: std::time::Duration::from_secs(1), |
There was a problem hiding this comment.
Since this is a mirror, it's always a local NATS message right? I'd only ask to make this configurable if this message will traverse over a real network boundary
There was a problem hiding this comment.
It will likely cross a network boundary. I'll bump this to 2s, but because this is temporary I don't really see a need to make it configurable
Please note that this is a bit big because I had to have a stream that combined internal wadm events with wasmbus ones. However, I did realize that we only care about streams for their configuration and delivery guarantees, and not for their storage capabilities. Because of this, we don't actually have to have the users configure the streams beforehand. So while this adds one more stream to manage combining the two topics (until nats 2.10 comes out and we move to it), the user no longer has to configure any of them. Closes wasmCloud#49 Signed-off-by: Taylor Thomas <taylor@cosmonic.com>
thomastaylor312
force-pushed
the
feat/notify_manifests
branch
from
593a575
to
b6aa026
Compare
brooksmtownsend
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note that this is a bit big because I had to have a stream that combined internal wadm events with wasmbus ones. However, I did realize that we only care about streams for their configuration and delivery guarantees, and not for their storage capabilities. Because of this, we don't actually have to have the users configure the streams beforehand. So while this adds one more stream to manage combining the two topics (until nats 2.10 comes out and we move to it), the user no longer has to configure any of them.
Closes #49