Experimental Support for Android (x86_64 and AArch64) #1292

igrep · 2020-03-12T01:10:49Z

Description

Related: #1113

Current Status

~~This pull request is a draft until the next version of libc crate (which should contain Add definitions in ucontext.h in Android for ARM, x86, and x86_64 rust-lang/libc#1622)~~
- Now released! 🎉
I confirmed the tests of wasmer-runtime-core pass on Android x86_64.
- The other tests including ones on AArch64 seems too hard so far... 😓

Review

Add a short description of the the change to the CHANGELOG.md file

Note

I'm happy given any hint to test of Android specific code (esp. in libc I added in rust-lang/libc#1622).

igrep · 2020-03-12T01:16:02Z

I confirmed the tests of wasmer-runtime-core pass on Android x86_64.
- The other tests including ones on AArch64 seems too hard so far... 😓

I've also pushed the test scripts in another branch.
Can I add them to the CI pipelines?

syrusakbary · 2020-03-12T02:58:34Z

Awesome!

Let's add this change into the CHANGELOG.md, so once libc publishes the new version we can merge it :)

syrusakbary · 2020-03-12T02:59:55Z

Can I add them to the CI pipelines?

We can merge the android tests in a separate PR. @igrep do you have any insight in how long take the tests to run with Android?

igrep · 2020-03-12T05:35:13Z

do you have any insight in how long take the tests to run with Android?

Here's the result of time of the test script on my laptop after cargo clean and adding --no-cache option to the docker command in the script:

> time ci/run-docker.sh x86_64-linux-android --manifest-path=lib/runtime-core-tests/Cargo.toml &> wasmer-test-result.txt

real    11m49.587s
user    0m0.340s
sys     0m0.355s

The test itself is fast enough: Most of the time is building the docker image.

MarkMcCaskey

I'm excited about this -- thanks!!

lib/singlepass-backend/src/lib.rs

Cargo.toml

syrusakbary · 2020-03-18T21:48:18Z

I'll merge the PR and do extra work in a PR apart

syrusakbary · 2020-03-18T21:48:48Z

bors r+

1292: Experimental Support for Android (x86_64 and AArch64) r=syrusakbary a=igrep # Description Related: #1113 # Current Status - ~~This pull request is a draft until the next version of libc crate (which should contain rust-lang/libc#1622 - Now released! 🎉 - I confirmed the tests of wasmer-runtime-core pass on Android x86\_64. - The other tests including ones on AArch64 seems too hard so far... 😓 # Review - [x] Add a short description of the the change to the CHANGELOG.md file # Note I'm happy given any hint to test of Android specific code (esp. in libc I added in rust-lang/libc#1622). Co-authored-by: Yuji Yamamoto <yuji-yamamoto@iij.ad.jp> Co-authored-by: YAMAMOTO Yuji <yuji-yamamoto@iij.ad.jp>

bors · 2020-03-18T22:15:24Z

Build failed

wasmerio.wasmer

igrep · 2020-03-19T01:39:47Z

I hasten to tell an issue before merging: I found a stack overflow error when running a simple WASI executable ("Hello, world" in Rust) on my Android phone (aarch64), not on an emulator (x86_64)

igrep · 2020-03-19T01:59:25Z

One more note: the first error reported by #1292 (comment) should have been fixed.

syrusakbary · 2020-03-19T02:01:19Z

bors try

syrusakbary · 2020-03-19T07:44:19Z

bors r+

1292: Experimental Support for Android (x86_64 and AArch64) r=syrusakbary a=igrep # Description Related: #1113 # Current Status - ~~This pull request is a draft until the next version of libc crate (which should contain rust-lang/libc#1622 - Now released! 🎉 - I confirmed the tests of wasmer-runtime-core pass on Android x86\_64. - The other tests including ones on AArch64 seems too hard so far... 😓 # Review - [x] Add a short description of the the change to the CHANGELOG.md file # Note I'm happy given any hint to test of Android specific code (esp. in libc I added in rust-lang/libc#1622). Co-authored-by: Yuji Yamamoto <yuji-yamamoto@iij.ad.jp> Co-authored-by: YAMAMOTO Yuji <yuji-yamamoto@iij.ad.jp> Co-authored-by: Syrus Akbary <me@syrusakbary.com>

bors · 2020-03-19T08:10:15Z

Build failed

wasmerio.wasmer

bors · 2020-03-20T19:22:04Z

try

Build failed

wasmerio.wasmer

I'll send a PR after rust-lang/libc#1622 is merged and released

The new version of libc contains changes necessary to build wasmer-runtime-core for Android. See rust-lang/libc#1622 for details.

Currently, at the time of 2020/03/11, testing on AArch64 is not supported in the upstream repository

igrep · 2020-03-23T03:30:57Z

bors try

bors · 2020-03-23T03:30:59Z

🔒 Permission denied

Existing reviewers: click here to make igrep a reviewer

MarkMcCaskey · 2020-03-23T03:38:15Z

bors try

syrusakbary · 2020-03-23T19:00:16Z

Somehow test didn't run ?
Let's try again:

bors try

bors · 2020-03-23T19:27:48Z

try

Build succeeded

syrusakbary · 2020-03-23T20:27:23Z

We should be good to merge once we solve the merge conflict @igrep!

syrusakbary · 2020-03-23T21:16:36Z

bors r+

bors · 2020-03-23T21:49:01Z

Build succeeded

wasmerio.wasmer
continuous-integration/travis-ci/push

Hywan added 🎉 enhancement New feature! 📦 lib-runtime labels Mar 12, 2020

MarkMcCaskey reviewed Mar 12, 2020

View reviewed changes

lib/singlepass-backend/src/lib.rs Outdated Show resolved Hide resolved

igrep force-pushed the android branch from 1f31247 to 6533875 Compare March 13, 2020 08:07

Hywan reviewed Mar 13, 2020

View reviewed changes

Cargo.toml Outdated Show resolved Hide resolved

igrep force-pushed the android branch 2 times, most recently from 67c9805 to 61f8278 Compare March 18, 2020 02:27

igrep added a commit to igrep/wasmer that referenced this pull request Mar 18, 2020

Add wasmerio#1292 to changelog

36f0ff6

igrep marked this pull request as ready for review March 18, 2020 02:31

igrep requested review from losfair and nlewycky as code owners March 18, 2020 02:31

syrusakbary reviewed Mar 18, 2020

View reviewed changes

Cargo.toml Outdated Show resolved Hide resolved

syrusakbary approved these changes Mar 18, 2020

View reviewed changes

igrep added a commit to igrep/wasmer that referenced this pull request Mar 19, 2020

Add wasmerio#1292 to changelog

2775b67

igrep force-pushed the android branch from 36f0ff6 to 2775b67 Compare March 19, 2020 01:40

bors bot added a commit that referenced this pull request Mar 20, 2020

Try #1292:

8bf9302

igrep added 7 commits March 23, 2020 11:55

Support Android

0df0a1c

I'll send a PR after rust-lang/libc#1622 is merged and released

🐛 Correct error message when trying to build on non-supported targets

b23436d

Update libc

96a0f85

The new version of libc contains changes necessary to build wasmer-runtime-core for Android. See rust-lang/libc#1622 for details.

enable testing on Android x86_64

93f6a9b

Currently, at the time of 2020/03/11, testing on AArch64 is not supported in the upstream repository

Add the android test script to the CI pipeline

056e9cf

Add wasmerio#1292 to changelog

a114b77

Fix build on CI for Android

18be0f2

igrep force-pushed the android branch from 401d186 to 18be0f2 Compare March 23, 2020 02:56

bors bot added a commit that referenced this pull request Mar 23, 2020

Try #1292:

e4fba34

wasmerio deleted a comment from bors bot Mar 23, 2020

Merge branch 'master' into android

9cdb49d

bors bot merged commit 4703e78 into wasmerio:master Mar 23, 2020

igrep deleted the android branch March 24, 2020 01:23

igrep mentioned this pull request Apr 15, 2020

Stack runs out when running a WASI executable on AArch64 iijlab/wasmonandroid#1

Open

frank-dspeed mentioned this pull request Jul 17, 2020

IOS Support open-pwa/open-pwa#3

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Experimental Support for Android (x86_64 and AArch64) #1292

Experimental Support for Android (x86_64 and AArch64) #1292

igrep commented Mar 12, 2020 •

edited

Loading

igrep commented Mar 12, 2020 •

edited

Loading

syrusakbary commented Mar 12, 2020

syrusakbary commented Mar 12, 2020

igrep commented Mar 12, 2020 •

edited

Loading

MarkMcCaskey left a comment

syrusakbary commented Mar 18, 2020

syrusakbary commented Mar 18, 2020

bors bot commented Mar 18, 2020

igrep commented Mar 19, 2020

igrep commented Mar 19, 2020

syrusakbary commented Mar 19, 2020

syrusakbary commented Mar 19, 2020

bors bot commented Mar 19, 2020

bors bot commented Mar 20, 2020

igrep commented Mar 23, 2020

bors bot commented Mar 23, 2020

MarkMcCaskey commented Mar 23, 2020

syrusakbary commented Mar 23, 2020

bors bot commented Mar 23, 2020

syrusakbary commented Mar 23, 2020 •

edited

Loading

syrusakbary commented Mar 23, 2020

bors bot commented Mar 23, 2020

Experimental Support for Android (x86_64 and AArch64) #1292

Experimental Support for Android (x86_64 and AArch64) #1292

Conversation

igrep commented Mar 12, 2020 • edited Loading

Description

Current Status

Review

Note

igrep commented Mar 12, 2020 • edited Loading

syrusakbary commented Mar 12, 2020

syrusakbary commented Mar 12, 2020

igrep commented Mar 12, 2020 • edited Loading

MarkMcCaskey left a comment

Choose a reason for hiding this comment

syrusakbary commented Mar 18, 2020

syrusakbary commented Mar 18, 2020

bors bot commented Mar 18, 2020

Build failed

igrep commented Mar 19, 2020

igrep commented Mar 19, 2020

syrusakbary commented Mar 19, 2020

syrusakbary commented Mar 19, 2020

bors bot commented Mar 19, 2020

Build failed

bors bot commented Mar 20, 2020

try

Build failed

igrep commented Mar 23, 2020

bors bot commented Mar 23, 2020

MarkMcCaskey commented Mar 23, 2020

syrusakbary commented Mar 23, 2020

bors bot commented Mar 23, 2020

try

Build succeeded

syrusakbary commented Mar 23, 2020 • edited Loading

syrusakbary commented Mar 23, 2020

bors bot commented Mar 23, 2020

Build succeeded

igrep commented Mar 12, 2020 •

edited

Loading

igrep commented Mar 12, 2020 •

edited

Loading

igrep commented Mar 12, 2020 •

edited

Loading

syrusakbary commented Mar 23, 2020 •

edited

Loading