Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[example/Waspello] Add Postgres instructions to README #663

Closed
matijaSos opened this issue Jul 4, 2022 · 2 comments · Fixed by #738
Closed

[example/Waspello] Add Postgres instructions to README #663

matijaSos opened this issue Jul 4, 2022 · 2 comments · Fixed by #738
Labels
documentation Improvements or additions to documentation example Example app good first issue Good for newcomers hacktoberfest This issue is perfect for HacktoberFest contributors

Comments

@matijaSos
Copy link
Contributor

Waspello is using Postgres but it isn't noted anywhere, so it is confusing for the users trying to run it. We should note it in Waspello's README and link to the docs where it is explained how to setup and run Postgres.
@matijaSos matijaSos added documentation Improvements or additions to documentation good first issue Good for newcomers no-haskell Coding task that does not need Haskell knowledge docs example Example app labels Jul 4, 2022
@matijaSos matijaSos mentioned this issue Jul 4, 2022
Open
@Martinsos
Copy link
Member

It would be even cooler if Wasp somehow nicely warned you about this and maybe provided some instructions!

@maksim36ua maksim36ua removed the no-haskell Coding task that does not need Haskell knowledge label Sep 20, 2022
@maksim36ua maksim36ua mentioned this issue Sep 28, 2022
Open
@h4r1337
Copy link
Contributor

h4r1337 commented Oct 2, 2022 •
edited
Loading

@matijaSos I can work on this. I will add the README first.

It would be even cooler if Wasp somehow nicely warned you about this and maybe provided some instructions!

@Martinsos I think it is better to create a separate issue for that...

h4r1337 added a commit to h4r1337/wasp that referenced this issue Oct 2, 2022
@h4r1337
Add README for [example/Waspello] (fix wasp-lang#663)
ff13058
@h4r1337 h4r1337 mentioned this issue Oct 2, 2022
Merged
@maksim36ua maksim36ua added the hacktoberfest This issue is perfect for HacktoberFest contributors label Oct 3, 2022
maksim36ua added a commit that referenced this issue Oct 12, 2022
@h4r1337 @Martinsos @maksim36ua
Add README for [example/Waspello] (fix #663) (#738)
6d0affa 
* Add README for [example/Waspello] (fix #663)

* Fix typo

* link to the wasp docs

* Fix typo [example/Waspello]

Co-authored-by: Martin Šošić <Martinsos@users.noreply.github.com>

* Mention the backend

Co-authored-by: Martin Šošić <Martinsos@users.noreply.github.com>
Co-authored-by: Max Khamrovskyi <maksim36ua@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation example Example app good first issue Good for newcomers hacktoberfest This issue is perfect for HacktoberFest contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add README for [example/Waspello] (fix #663) h4r1337/wasp
4 participants
@Martinsos @matijaSos @maksim36ua @h4r1337