Fix the auth helpers to only require fields they need from AuthIdentity
#2057
Conversation
Signed-off-by: Mihovil Ilakovac <mihovil@ilakovac.com>
| @@ -130,6 +132,8 @@ const TaskView = ({ task }: { task: Task }) => { | |||
| } | |||
| } | |||
|
|
|||
| const email = getEmail(task.user) | |||
There was a problem hiding this comment.
Using the helper in the headless tests.
There was a problem hiding this comment.
Using the getEmail helper in headless tests app to test it in headless tests :)
| @@ -30,7 +30,7 @@ genAuth spec = | |||
| Just auth -> | |||
| -- shared stuff | |||
| sequence | |||
| [ genUserTs | |||
| [ genFileCopy [relfile|auth/user.ts|] | |||
There was a problem hiding this comment.
No need for templating anymore for this file, I've used a copy file draft instead.
infomiho
changed the title
AuthIdentity
infomiho
changed the title
AuthIdentityAuthIdentity
| return tasks | ||
| } | ||
| }) satisfies GetTasks<void> |
There was a problem hiding this comment.
How come the frontend type tests aren't complaining about this?
Different todoApp. Boy, they really are diverging 😅
There was a problem hiding this comment.
This is always a good thing to do in TypeScript (use the structural type system define arguments to have as few constraints as possible).
There's also an item in Effective TypeScript that talks about it.
One thing I'd possibly like changed. If the MinimalUserEntityWithAuth is the type users will be seeing the most of, I recommend flipping the naming:
- Change
MinimalUserEntityWithAuthtoUserEntityWithAuth - Change
UserEntityWithAuthto something more verbose.
|
Good point! The tricky part with the The problem is that the user will see this wacky (albeit correct) name, and we want to do better. Some alternatives:
I maybe like the first option the best since it's just a |
| @@ -49,7 +51,7 @@ function makeAuthUser(data: AuthUserData): AuthUser { | |||
| }; | |||
| } | |||
|
|
|||
| function findUserIdentity(user: UserEntityWithAuth, providerName: ProviderName): {= authIdentityEntityName =} | null { | |||
| function findUserIdentity(user: UserEntityWithAuth, providerName: ProviderName): UserEntityWithAuth['auth']['identities'][number] | null { | |||
| @@ -130,6 +132,8 @@ const TaskView = ({ task }: { task: Task }) => { | |||
| } | |||
| } | |||
|
|
|||
| const email = getEmail(task.user) | |||
The auth helpers like
getEmailandgetUsernamedidn't work unless you provided the full user object with fullAuthIdentityobjects in theidentitiesarray.Given that we suggest to users to include only the
providerNameandproviderUserIdwhen manually fetching the user + auth + identities, we should make sure our auth helpers work in that scenario.This PR:
providerNameandproviderUserIdwhen using the helpers.