Skip to content
This repository has been archived by the owner on Mar 12, 2024. It is now read-only.

Extract functions and texts (#323) #325

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Conversation

EstebanDalelR
Copy link
Member

Description

Uses the extracted functions

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Chore: cleanup/renaming, etc
  • RFC

Notes

Acceptance

@vercel
Copy link

vercel bot commented Oct 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
watermelon ✅ Ready (Inspect) Visit Preview Oct 11, 2023 9:32pm

@watermelon-copilot-for-code-review

WatermelonAI Summary

Commit 1: The commit message "Extract functions and texts" and the PR title and body indicate that this commit involves extracting functions and texts from the codebase. This suggests a refactoring or reorganization of the code to improve modularity and readability. The extracted functions are then used in the code, indicating a reuse of common logic. This is likely a chore-type of change focused on cleanup and improving maintainability.

GitHub PRs

Click here to login to Jira
Click here to login to Confluence
Slack Threads deactivated by EstebanDalelR

Notion Pages

Linear Tickets deactivated by EstebanDalelR
Click here to login to Asana
watermelon is an open repo and Watermelon will serve it for free.
🍉🫶

Copy link
Collaborator

@baristaGeek baristaGeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this was already merged, didn't it? Anyway, LGTM because of DRY principle

@EstebanDalelR
Copy link
Member Author

I thought this was already merged, didn't it? Anyway, LGTM because of DRY principle

It was a stack one, to another PR, which was merged without this.

@EstebanDalelR EstebanDalelR merged commit 63b0933 into dev Oct 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants