New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DateField and DateTimeField - Accept inputs that behave like Date #969

Merged

titusfortner merged 1 commit into watir:main from jkotests:datefield_support_timewithzone

Apr 19, 2023

Member

jkotests commented Apr 17, 2023

Setting a DateField or DateTimeField currently requires a String, Date or Time. This can be too strict.

For example, it prevents using ActiveSupport with time zones:

require 'active_support/time'

Time.zone = 'Stockholm'
browser.date_field.set(2.months.ago)
#=> ArgumentError (DateField#set only accepts instances of Date or Time)

This PR proposes accepting any object that responds to #strftime.


          DateField and DateTimeField - Accept inputs that behave like Date

e1badec

jkotests requested a review from titusfortner

April 17, 2023 06:14

titusfortner approved these changes

View reviewed changes

Member

titusfortner left a comment

Agreed. Thanks.

titusfortner merged commit fa4c685 into watir:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet