-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ignore unecessary files for npm releases #962
Conversation
Codecov Report
@@ Coverage Diff @@
## master #962 +/- ##
=======================================
Coverage 64.28% 64.28%
=======================================
Files 2 2
Lines 14 14
Branches 3 3
=======================================
Hits 9 9
Misses 4 4
Partials 1 1 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for doing this!
The builds have been failing on |
Yeah, looks like Travis all of a sudden stopped inserting a default |
That's what I noticed too and actually added an explicit install step in this PR but there was still an issue with the Typedoc generator so I need to fix things there as well. Should hopefully have something up soon |
Turns out, there were some edits I made to the build for the release candidate branch that messed up some things in master. The releases should be going out shortly |
🎉 This PR is included in version 4.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Fixes #952
Adds npmignore rules for files that are not necessary for the NPM install to work, which should slim down the size of the npm install by ~926kb.
Checklist
npm test
passes (tip:npm run autofix
can correct most style issues)