Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove unneeded object.assign devDependency #955

Merged
merged 1 commit into from
Sep 16, 2019
Merged

refactor: remove unneeded object.assign devDependency #955

merged 1 commit into from
Sep 16, 2019

Conversation

MasterOdin
Copy link
Contributor

The object.assign package is unnecessary if using Node 4+ when the Object.assign method became available. It looks like other tests use Object.assign as well already.

Checklist
  • npm test passes (tip: npm run autofix can correct most style issues)

@codecov-io
Copy link

codecov-io commented Sep 13, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-candidate-v5@600f9e0). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                   Coverage Diff                   @@
##             release-candidate-v5     #955   +/-   ##
=======================================================
  Coverage                        ?   64.28%           
=======================================================
  Files                           ?        2           
  Lines                           ?       14           
  Branches                        ?        3           
=======================================================
  Hits                            ?        9           
  Misses                          ?        4           
  Partials                        ?        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 600f9e0...614552d. Read the comment docs.

germanattanasio
germanattanasio approved these changes Sep 16, 2019
View reviewed changes
Copy link
Contributor

@germanattanasio germanattanasio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @MasterOdin

dpopp07
dpopp07 approved these changes Sep 16, 2019
View reviewed changes
Copy link
Contributor

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! 👍

@dpopp07 dpopp07 merged commit 2c72ad5 into watson-developer-cloud:release-candidate-v5 Sep 16, 2019
dpopp07 pushed a commit that referenced this pull request Sep 19, 2019
@MasterOdin @dpopp07
refactor: remove unneeded object.assign devDependency (#955)
0a578d7
@MasterOdin MasterOdin deleted the object_assign branch September 27, 2019 12:00
dpopp07 pushed a commit that referenced this pull request Oct 4, 2019
@MasterOdin @dpopp07
refactor: remove unneeded object.assign devDependency (#955)
263d713
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpopp07 dpopp07 dpopp07 approved these changes

@germanattanasio germanattanasio germanattanasio approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MasterOdin @codecov-io @germanattanasio @dpopp07