Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update @commitlint/cli and husky dev dependencies #959

Merged
merged 2 commits into from
Sep 17, 2019
Merged

chore: update @commitlint/cli and husky dev dependencies #959

merged 2 commits into from
Sep 17, 2019

Conversation

MasterOdin
Copy link
Contributor

@MasterOdin MasterOdin commented Sep 17, 2019

Updates the @commitlint dependencies to their latest versions, fixing another 5 vulnerability reports from running npm install. The big change from 7.* to 8.* was:

However, this has no effect in usage with husky, and the usage string remains the same. However, given their connection, I also updated husky as well from 1.* to 2.* where the breaking change was that it dropped Node 6 support. The commitlint repo dropped Node 6 support on the 8.1.0 release.

There is an even newer version of husky (v3) that is available, but it adds a requirement on having git >= 2.13.2 which is probably largely true on most systems, but figured that might be a bit too breaking. However, if it's decided that's not really that big of an issue, there is no issue moving to v3 from v2.

Checklist
  • npm test passes (tip: npm run autofix can correct most style issues)

@MasterOdin MasterOdin changed the title refactor: update @commitlint/cli and husky chore: update @commitlint/cli and husky dev dependencies Sep 17, 2019
@codecov-io
Copy link

codecov-io commented Sep 17, 2019

Codecov Report

Merging #959 into release-candidate-v5 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                  Coverage Diff                  @@
##           release-candidate-v5     #959   +/-   ##
=====================================================
  Coverage                 64.28%   64.28%           
=====================================================
  Files                         2        2           
  Lines                        14       14           
  Branches                      3        3           
=====================================================
  Hits                          9        9           
  Misses                        4        4           
  Partials                      1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac29153...94808c2. Read the comment docs.

Copy link
Contributor

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with all you've said here, looks good. Thanks!

@dpopp07 dpopp07 merged commit 0af5b42 into watson-developer-cloud:release-candidate-v5 Sep 17, 2019
dpopp07 pushed a commit that referenced this pull request Sep 19, 2019
* chore: update @commitlint/cli to latest version
* chore: update husky to 2.7.0
@MasterOdin MasterOdin deleted the update_commitlint branch September 27, 2019 12:00
dpopp07 pushed a commit that referenced this pull request Oct 4, 2019
* chore: update @commitlint/cli to latest version
* chore: update husky to 2.7.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants