Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update handlebars in package-lock tree #970

Merged
merged 1 commit into from
Sep 26, 2019
Merged

chore: update handlebars in package-lock tree #970

merged 1 commit into from
Sep 26, 2019

Conversation

MasterOdin
Copy link
Contributor

Updates handlebars in the package-lock tree (used as a sub-dependency by three packages), getting rid of 3 new NPM audit vulnerabilities related to a prototype pollution issue. All of the affected dependencies are devDependencies (jest, semantic-release through three layers of sub-dependencies, and typdoc).

Checklist
  • npm test passes (tip: npm run autofix can correct most style issues)

@codecov-io
Copy link

codecov-io commented Sep 25, 2019

Codecov Report

Merging #970 into release-v5-rc2 will increase coverage by 11.11%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release-v5-rc2     #970       +/-   ##
===================================================
+ Coverage           77.77%   88.88%   +11.11%     
===================================================
  Files                   1        1               
  Lines                   9        9               
  Branches                2        2               
===================================================
+ Hits                    7        8        +1     
+ Misses                  2        1        -1
Impacted Files Coverage Δ
test/resources/auth_helper.js 88.88% <0%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c27052...a2c9393. Read the comment docs.

Copy link
Contributor

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thanks!

@dpopp07 dpopp07 merged commit 86e8ca3 into watson-developer-cloud:release-v5-rc2 Sep 26, 2019
@MasterOdin MasterOdin deleted the update_handlebars branch September 27, 2019 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants