Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(typing): add @types/async and fix typing for its usage #972

Merged
merged 1 commit into from
Sep 30, 2019
Merged

Conversation

MasterOdin
Copy link
Contributor

This adds @types/async and fixes an incompatible type that was being passed to it (it requires a concrete usage of interval and times, which is provided via the use of extend where the CheckParams interface is used.

Checklist
  • npm test passes (tip: npm run autofix can correct most style issues)

@codecov-io
Copy link

codecov-io commented Sep 27, 2019

Codecov Report

Merging #972 into release-v5-rc2 will increase coverage by 11.11%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release-v5-rc2     #972       +/-   ##
===================================================
+ Coverage           77.77%   88.88%   +11.11%     
===================================================
  Files                   1        1               
  Lines                   9        9               
  Branches                2        2               
===================================================
+ Hits                    7        8        +1     
+ Misses                  2        1        -1
Impacted Files Coverage Δ
test/resources/auth_helper.js 88.88% <0%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db2e84c...bd5d0d4. Read the comment docs.

@germanattanasio
Copy link
Contributor

@MasterOdin Thanks for the PR, I tried to look you up and found that your website is down http://www.mpeveler.com.

Copy link
Contributor

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! 👍

@dpopp07 dpopp07 merged commit 0ea12f6 into watson-developer-cloud:release-v5-rc2 Sep 30, 2019
@MasterOdin
Copy link
Contributor Author

@germanattanasio Yeah, I keep meaning to find a day to re-setup my entire server after I borked it which had my site. In the meantime, I've put up a static site based out of github to make https://mpeveler.com accessible again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants