Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update documentation for webpack #977

Merged
merged 1 commit into from
Oct 3, 2019
Merged

chore: update documentation for webpack #977

merged 1 commit into from
Oct 3, 2019

Conversation

christiancompton
Copy link

This change accompanies changes in the Node-SDK-Core which eliminate the requirement of adding special configuration (polyfills) in bundlers like webpack. The workarounds are still required for versions <5.0.0 of the SDK.

Checklist
  • npm test passes (tip: npm run autofix can correct most style issues)
  • documentation is changed or added

@CLAassistant
Copy link

CLAassistant commented Oct 3, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@dpopp07 dpopp07 self-requested a review October 3, 2019 20:28
dpopp07
dpopp07 approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@christiancompton christiancompton merged commit a0da761 into release-v5-rc2 Oct 3, 2019
@christiancompton christiancompton deleted the browser-docs branch October 3, 2019 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpopp07 dpopp07 dpopp07 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christiancompton @CLAassistant @dpopp07