Regen trial v5 #978
Merged
Regen trial v5 #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
but should generate discovery using |
Codecov Report
@@ Coverage Diff @@
## release-v5-rc2 #978 +/- ##
===============================================
Coverage ? 100%
===============================================
Files ? 1
Lines ? 9
Branches ? 2
===============================================
Hits ? 9
Misses ? 0
Partials ? 0Continue to review full report at Codecov.
|
* update the tests to match the style guide
dpopp07
force-pushed
the
regen-trial-v5
branch
from
d0503ed
to
0ff0854
Compare
dpopp07
added a commit
that referenced
this pull request
Oct 4, 2019
* refactor: update authorization, stt, and tts to handle promises from the core * refactor: all service methods now return a Promise by default - callbacks are still supported * chore: support array parameters in visual recognition * build: bump core version to 1.0.0 * docs: update the migration guide with final service updates * chore: make `prefix` required in method `getAutocomplete` * update the tests to match the style guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full regeneration and reliance on the official release of the core. Getting this into the release branch before I finish the readme/migration and open a PR for the release.
The majority of the changes are for the Promises work.