Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows 10 Title-bar and visuals (Feature Request) #36

Open
karsyboy opened this issue Apr 8, 2017 · 11 comments
Open

Windows 10 Title-bar and visuals (Feature Request) #36

karsyboy opened this issue Apr 8, 2017 · 11 comments

Comments

@karsyboy
Copy link

karsyboy commented Apr 8, 2017

Just a request since we have to pay for wmail now can we please have the tittlebar on windows look more visually pleasing. The interface one window doesn't have as nice of a feeling as it does on MacOS and Linux. I would love if this could be changed since we have to pay now.

@karsyboy karsyboy changed the title Feature Request Windows 10 Title-bar and visuals (Feature Request) Apr 8, 2017
@karsyboy
Copy link
Author

karsyboy commented Apr 8, 2017

Something like this, please!!!
capture

@karsyboy
Copy link
Author

karsyboy commented Apr 8, 2017

all that was done in this electron code is they disabled the windows from and then used a css script to make a nice style one on top.

@Thomas101
Copy link
Member

Hi @karsyboy thanks for getting in touch. Now that I have more time to spend on Wavebox, I can start to work on things like this. As Wavebox supports more than just Google inbox, having a title that bleeds in like the screenshot is probably not going to work as when you switch across to gmail you'll be left with the blue or a constantly changing colour bar.

There's probably a few options here...

  1. Add the window buttons into the same position as what they are on osx. This does have the downside that the icons are on the wrong side. Probably quite annoying. On the plus side though doesn't take any extra screen estate.
  2. I can add in a title bar for windows and give it a generic color. This comes at the expense of screen estate though.
  3. Same as 2, but could try to pick the default coloring used by the user

It would be good to get some feedback on what you think on this

@karsyboy
Copy link
Author

I like the idea of making it what its like in osx and would not mind this the design is clean and in my own option having it on the other side isnt a big deal.
I also like the idea os being able to change the tittle bar color in setting.
But to be honest im not a 100% sure on which one I just know the design in windows with the frame and everything else going one makes it look weird.

@Thomas101 Thomas101 added this to the Version 3.2 milestone Apr 11, 2017
@Thomas101
Copy link
Member

Lets look at adding it into a similar position as OSX first and then see how that works. We can always re-look at adding in a stylized titlebar as a further option later on

@weaversam8
Copy link

I'd +1 this issue. Having Wavebox also change the title bar color based on the app open could be a great solution as well. If you look at the beta channel of the Slack desktop app for Windows, it uses CSS to create a Windows 10-esque bar that matches the team style.

@Thomas101
Copy link
Member

This has been added into 3.1.4 which is now live. It's still a little bit experimental, but you can enable it by going to settings and toggling Show Titlebar to off. Would be great to have some feedback on this, I think there's still a little bit more work to do on this feature

Wavebox should update automatically after a while, but if you want to hurry it up, just restart the app and it will re-check

@weaversam8
Copy link

This is more what I had in mind, but what you did is certainly a start. I think this is more of an opinionated topic.

image

@Thomas101
Copy link
Member

I think there's room for both here - as you said opinionated topic. Will re-open and look at adding a bar option

@Thomas101 Thomas101 reopened this Apr 15, 2017
@Thomas101 Thomas101 modified the milestones: Version 3.2, Version 3.3 Aug 2, 2017
@Thomas101 Thomas101 modified the milestone: Version 3.3 Aug 29, 2017
@nmat
Copy link
Contributor

nmat commented Nov 14, 2017

going to test this and get back with result

@nmat
Copy link
Contributor

nmat commented Nov 24, 2017

Here is the github desktop app layout also which is interesting:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants