if border is true, set border attrib on table to 1 #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the suggestion. However I will not be merging this pull request. Please see my response to issue #74 for a full explanation of why I will not consider any additions to the table extension. Even if that wasn't the case, this extension is intended to be a clone of PHP Markdown Extra's behavior. Therefore, I would not accept the new behavior for that reason either. For that matter, the feature you are asking for seems more like something that should be implemented through CSS, not HTML, which is outside the cope of Markdown. If you would still like to have this feature, then my suggestion would be to release it as a third party extension and list it on the wiki for others to find. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.