-
Notifications
You must be signed in to change notification settings - Fork 886
support empty table #400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support empty table #400
Conversation
1 similar comment
@pieterprovoost thank you for your submission. However, before I accept your PR, please review my response to #74. Does the change you made more closely match the behavior of tables in PHP Markdown Extra? If so, could you provide an example table (preferably as a test that fails without your change and passes with it). If not, then may I suggest you fork the existing extension and make it do whatever you want -- or perhaps a third party extension already exists that meets your needs. |
@waylan PHP Markdown supports zero rows, so this change does make Python Markdown more like PHP Markdown. This test fails with the current version:
|
Thanks. If you add a test here, I'll accept it. |
@waylan I added the test to my branch, but it's not picked up? https://github.com/pieterprovoost/Python-Markdown/commit/47737e4a515e63e21bbfd2d2b35404fe44432890 |
Well, you didn't also update the corresponding HTML file which provides the expected output for the test to compare against. If you run Although now that I take a second look, I see that the tests are passing, which is odd. Does the |
No description provided.