Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty file upload #4176

Merged
merged 4 commits into from
Jun 2, 2022
Merged

Empty file upload #4176

merged 4 commits into from
Jun 2, 2022

Conversation

yenienserrano
Copy link
Member

Description:

When trying to import an empty file in rules or decoders, there was no information, it let you upload it but it had no effect, I added a warning to let the user know that he is uploading an empty file and not to let him upload it.

Test:

  1. Navigate to Management/rules or decoders
  2. Try uploading an empty file
  3. See the warning

Issue:

Screenshot:

image

@yenienserrano yenienserrano requested a review from a team May 27, 2022 15:16
@Mayons95 Mayons95 self-requested a review May 27, 2022 19:40
@yenienserrano yenienserrano self-assigned this Jun 2, 2022
public/controllers/management/components/upload-files.js Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
Copy link
Member

@AlexRuiz7 AlexRuiz7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️
Screenshot from 2022-06-02 12-42-31

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2022

Jest Test Coverage % values
Statements 4.09% ( 1489 / 36375 )
Branches 1.68% ( 473 / 28238 )
Functions 3.06% ( 272 / 8900 )
Lines 4.14% ( 1440 / 34793 )

@AlexRuiz7 AlexRuiz7 merged commit 8200376 into 4.3-7.10 Jun 2, 2022
@AlexRuiz7 AlexRuiz7 deleted the fix/4059-empty-file-upload branch June 2, 2022 10:58
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2022

The backport to 4.3-7.16 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.3-7.16 4.3-7.16
# Navigate to the new working tree
cd .worktrees/backport-4.3-7.16
# Create a new branch
git switch --create backport-4176-to-4.3-7.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 82003767adabc6b0f59bbb94b91d5ec8fb5b3638
# Push it to GitHub
git push --set-upstream origin backport-4176-to-4.3-7.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.3-7.16

Then, create a pull request where the base branch is 4.3-7.16 and the compare/head branch is backport-4176-to-4.3-7.16.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2022

The backport to 4.3-1.2-wzd failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.3-1.2-wzd 4.3-1.2-wzd
# Navigate to the new working tree
cd .worktrees/backport-4.3-1.2-wzd
# Create a new branch
git switch --create backport-4176-to-4.3-1.2-wzd
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 82003767adabc6b0f59bbb94b91d5ec8fb5b3638
# Push it to GitHub
git push --set-upstream origin backport-4176-to-4.3-1.2-wzd
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.3-1.2-wzd

Then, create a pull request where the base branch is 4.3-1.2-wzd and the compare/head branch is backport-4176-to-4.3-1.2-wzd.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2022

The backport to cloud/4.3-7.10 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-cloud/4.3-7.10 cloud/4.3-7.10
# Navigate to the new working tree
cd .worktrees/backport-cloud/4.3-7.10
# Create a new branch
git switch --create backport-4176-to-cloud/4.3-7.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 82003767adabc6b0f59bbb94b91d5ec8fb5b3638
# Push it to GitHub
git push --set-upstream origin backport-4176-to-cloud/4.3-7.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-cloud/4.3-7.10

Then, create a pull request where the base branch is cloud/4.3-7.10 and the compare/head branch is backport-4176-to-cloud/4.3-7.10.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2022

The backport to cloud/4.3-7.10-custom-agents-view failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-cloud/4.3-7.10-custom-agents-view cloud/4.3-7.10-custom-agents-view
# Navigate to the new working tree
cd .worktrees/backport-cloud/4.3-7.10-custom-agents-view
# Create a new branch
git switch --create backport-4176-to-cloud/4.3-7.10-custom-agents-view
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 82003767adabc6b0f59bbb94b91d5ec8fb5b3638
# Push it to GitHub
git push --set-upstream origin backport-4176-to-cloud/4.3-7.10-custom-agents-view
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-cloud/4.3-7.10-custom-agents-view

Then, create a pull request where the base branch is cloud/4.3-7.10-custom-agents-view and the compare/head branch is backport-4176-to-cloud/4.3-7.10-custom-agents-view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No error message is displayed when uploading an empty file
4 participants