Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed ST2 restriction for Composer plugin now that master supports ST3 #2381

Merged
merged 2 commits into from
Nov 19, 2013

Conversation

Stubbs
Copy link
Contributor

@Stubbs Stubbs commented Nov 19, 2013

The package maintainer for Composer now supports ST3, it's on the same branch as ST2 support so the best way to make it available is to remove the ST2 only restriction.

@FichteFoll
Copy link
Collaborator

Sorry, but you may not remove the version selector. In order to make it match ST3 you have to set it to *.

@Stubbs
Copy link
Contributor Author

Stubbs commented Nov 19, 2013

Ok, added the * to indicate ST2 & 3 support.

FYI, I removed it based on this comment in https://raw.github.com/wbond/sublime_package_control/master/example-repository.json

// Could also be >2999 for ST3. Leaving this out indicates
// the package works with both ST2 and ST3.

FichteFoll added a commit that referenced this pull request Nov 19, 2013
Removed ST2 restriction for Composer plugin now that master supports ST3
@FichteFoll FichteFoll merged commit 6aeae0c into wbond:master Nov 19, 2013
@FichteFoll
Copy link
Collaborator

Yeah, for some reason @wbond doesn't pull my changes (wbond/package_control#628). Maybe he is really, really busy, but people have been mentioning this over and over again and it's kinda annoying that I actually already made the changes but nobody can see them.

@Stubbs
Copy link
Contributor Author

Stubbs commented Nov 19, 2013

ah, fair enough. Thanks for letting me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants