fix: horizon supervisor does not consider job level timeouts #771
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket https://phabricator.wikimedia.org/T342866
It seems that when using Horizon to supervise jobs, job level timeouts are not being considered. Instead only the Horizon config itself will be used. Jobs can still timeout themselves.
Currently, this means that long running jobs like
PollForMediaWikiJobs
will timeout after 60s in production.As we probably still want job level granularity for setting this value, this PR changes:
$timeout
property