fix(site-stats): logic for fetching first revision is broken #814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m90
force-pushed
the
fr/stats-fixes
branch
2 times, most recently
from
427c597 to
28d89bc
Compare
Currently two things go wrong: - revid 1 does not neccessarily exist - the platform reserved user should be excluded
| 'format' => 'json', | ||
| 'prop' => 'revisions', | ||
| 'rvprop' => 'timestamp', | ||
| 'revids' => $firstRevision, |
There was a problem hiding this comment.
Did you mean to use 'formatversion' => 2? Currently, the API returns a map of pages instead of an array, which breaks the subsequent data_get(..., 'query.pages.0.revisions.0.timestamp').
There was a problem hiding this comment.
Ah yeah, good catch, that got lost when I refactored things lateron. WIll fix.
AndrewKostka
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tickets https://phabricator.wikimedia.org/T366702 and https://phabricator.wikimedia.org/T364991
Previously, the logic was built on the assumption that the first revision to consider:
1This created two problems:
1did not existInstead, this PR changes the logic to be:
which fixes both problems