Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate linter dependency on parser #30

Closed
wcjohnson opened this issue Oct 3, 2017 · 0 comments
Closed

Eliminate linter dependency on parser #30

wcjohnson opened this issue Oct 3, 2017 · 0 comments
Labels
enhancement linter
Milestone
3.0

Comments

@wcjohnson
Copy link
Owner

wcjohnson commented Oct 3, 2017 •
edited
Loading

Linter should get its parser dependency by way of the plugin, most likely through the plugin exposing the parser as an API.

  • Note: Linter grabs some parser internals, see require block at top of index.js
  • There are probably some shenaningans going on here re parser configuration. Plugins can change tokenTypes which may mean the linter needs to delay grabbing those until after config is read.
wcjohnson added a commit to wcjohnson/lightscript-eslint that referenced this issue Oct 9, 2017
@wcjohnson
Linter uses tooling API
4197163 
wcjohnson/lightscript#30
wcjohnson/lightscript#31
@wcjohnson wcjohnson added this to the 3.0 milestone Oct 9, 2017
wcjohnson added a commit to wcjohnson/lightscript-eslint that referenced this issue Oct 25, 2017
@wcjohnson
3.0
30af98b 
commit 3dfd2ff
Author: William C. Johnson <wcjohnson@oigroup.net>
Date:   Wed Oct 25 00:32:52 2017 -0400

    @oigroup/lightscript-eslint@3.0.0-beta.9

commit 2d842e6
Author: William C. Johnson <wcjohnson@oigroup.net>
Date:   Wed Oct 25 00:10:30 2017 -0400

    @oigroup/lightscript-eslint@3.0.0-beta.8

commit ae1363a
Author: William C. Johnson <wcjohnson@oigroup.net>
Date:   Tue Oct 24 23:54:50 2017 -0400

    @oigroup/lightscript-eslint@3.0.0-beta.7

commit f74e487
Author: William C. Johnson <wcjohnson@oigroup.net>
Date:   Sun Oct 22 15:18:19 2017 -0400

    @oigroup/lightscript-eslint@3.0.0-beta.6

commit 8117e94
Author: William C. Johnson <wcjohnson@oigroup.net>
Date:   Fri Oct 20 21:02:16 2017 -0400

    @oigroup/lightscript-eslint@3.0.0-beta.5

commit 046d90b
Author: William C. Johnson <wcjohnson@oigroup.net>
Date:   Thu Oct 19 16:51:39 2017 -0400

    @oigroup/lightscript-eslint@3.0.0-beta.4

commit 6cfb623
Author: William C. Johnson <wcjohnson@oigroup.net>
Date:   Thu Oct 19 16:48:27 2017 -0400

    Disable no-else-return rule

    Doc updates also

commit 8fb9ef8
Author: William C. Johnson <wcjohnson@oigroup.net>
Date:   Thu Oct 12 22:31:36 2017 -0400

    Disable `no-unexpected-multiline` in eslint 4

commit 3dabeae
Author: William C. Johnson <wcjohnson@oigroup.net>
Date:   Thu Oct 12 21:08:36 2017 -0400

    @oigroup/lightscript-eslint@3.0.0-beta.3

commit ce3ba57
Author: William C. Johnson <wcjohnson@oigroup.net>
Date:   Thu Oct 12 20:18:51 2017 -0400

    @oigroup/lightscript-eslint@3.0.0-beta.2

commit d7945d6
Author: William C. Johnson <wcjohnson@oigroup.net>
Date:   Thu Oct 12 20:06:28 2017 -0400

    Packaging updates

commit fb7c378
Author: William C. Johnson <wcjohnson@oigroup.net>
Date:   Thu Oct 12 20:03:24 2017 -0400

    Update deps

commit 97cae1f
Author: William C. Johnson <wcjohnson@oigroup.net>
Date:   Thu Oct 12 18:11:10 2017 -0400

    Post-merge fixups

commit 1c30620
Merge: 5721d25 54ed517
Author: William C. Johnson <wcjohnson@oigroup.net>
Date:   Thu Oct 12 18:05:41 2017 -0400

    Merge remote-tracking branch 'babel-eslint/7.x' into prerelease/3.0.0

    # Conflicts:
    #	README.md
    #	babylon-to-espree/toAST.js
    #	index.js
    #	package.json
    #	test/non-regression.js
    #	yarn.lock

commit 5721d25
Author: William C. Johnson <wcjohnson@oigroup.net>
Date:   Thu Oct 12 17:20:09 2017 -0400

    Remove separate `pickBy` dep

commit 6bd6f19
Author: William C. Johnson <wcjohnson@oigroup.net>
Date:   Wed Oct 11 21:38:51 2017 -0400

    @oigroup/lightscript-eslint@3.0.0-beta.1

commit fe34c6c
Author: William C. Johnson <wcjohnson@oigroup.net>
Date:   Wed Oct 11 01:24:05 2017 -0400

    @oigroup/lightscript-eslint@3.0.0-beta.0

commit 52dadaa
Author: William C. Johnson <wcjohnson@oigroup.net>
Date:   Wed Oct 11 01:15:42 2017 -0400

    Monkey-patch getFirstTokens

commit 4197163
Author: William C. Johnson <wcjohnson@oigroup.net>
Date:   Sun Oct 8 21:31:37 2017 -0400

    Linter uses tooling API

    wcjohnson/lightscript#30
    wcjohnson/lightscript#31

commit ab96233
Author: William C. Johnson <wcjohnson@oigroup.net>
Date:   Sun Oct 8 16:35:32 2017 -0400

    @oigroup/lightscript-eslint@3.0.0-alpha.6

commit ea1ddf6
Author: William C. Johnson <wcjohnson@oigroup.net>
Date:   Sun Oct 8 16:34:20 2017 -0400

    Catch up to plugin

commit 8c36f6c
Author: William C. Johnson <wcjohnson@oigroup.net>
Date:   Fri Oct 6 17:49:53 2017 -0400

    @oigroup/lightscript-eslint@3.0.0-alpha.5

commit 3f9444e
Author: William C. Johnson <wcjohnson@oigroup.net>
Date:   Tue Oct 3 15:26:06 2017 -0400

    @oigroup/lightscript-eslint@3.0.0-alpha.4

commit f1ea213
Author: William C. Johnson <wcjohnson@oigroup.net>
Date:   Mon Oct 2 21:36:21 2017 -0400

    @oigroup/lightscript-eslint@3.0.0-alpha.3

commit 8dcd15b
Author: William C. Johnson <wcjohnson@oigroup.net>
Date:   Mon Oct 2 21:35:09 2017 -0400

    Patch linter for 3.0 alpha changes

commit f35f5bb
Author: William C. Johnson <wcjohnson@oigroup.net>
Date:   Sat Sep 30 22:09:47 2017 -0400

    @oigroup/lightscript-eslint@3.0.0-alpha.2

commit 9b3c535
Author: William C. Johnson <wcjohnson@oigroup.net>
Date:   Thu Sep 28 21:27:31 2017 -0400

    @oigroup/lightscript-eslint@3.0.0-alpha.1

commit 7e0882e
Author: William C. Johnson <wcjohnson@oigroup.net>
Date:   Thu Sep 28 21:15:46 2017 -0400

    Update comprehension syntax

commit deb1718
Author: William C. Johnson <wcjohnson@oigroup.net>
Date:   Wed Sep 27 22:17:27 2017 -0400

    @oigroup/lightscript-eslint@3.0.0-alpha.0

commit 57160c5
Author: William C. Johnson <wcjohnson@oigroup.net>
Date:   Wed Sep 27 22:06:26 2017 -0400

    3.0 defaults update

commit 1b5e466
Author: William C. Johnson <wcjohnson@oigroup.net>
Date:   Wed Sep 27 22:06:20 2017 -0400

    Quieted unmapped node message

commit 54ed517
Author: Reyad Attiyat <reyad.attiyat@gmail.com>
Date:   Mon May 29 20:41:14 2017 -0500

    Fix: Convert RegExpLieteral value to RegExp object (fixes babel#477) (babel#478)

commit 94bb5a1
Author: Sebastian McKenzie <sebmck@fb.com>
Date:   Fri Apr 21 22:14:19 2017 +0100

    7.2.3

commit dfaff04
Author: Andres Suarez <zertosh@gmail.com>
Date:   Fri Apr 21 11:48:52 2017 -0400

    Fix flow type spread handling (babel#465)

commit f59d200
Author: Henry Zhu <hi@henryzoo.com>
Date:   Wed Apr 12 12:07:05 2017 -0400

    7.2.2

commit 8622009
Author: Vitor Balocco <vitorbal@gmail.com>
Date:   Wed Apr 12 17:59:23 2017 +0200

    Fix: use eslint-scope instead of escope if present (babel#461)

commit 0f611b8
Author: Andres Suarez <zertosh@gmail.com>
Date:   Thu Mar 30 13:49:51 2017 -0400

    Separate finding peer deps from monkeypatching (babel#460)

commit 1201e12
Author: Andres Suarez <zertosh@gmail.com>
Date:   Sat Mar 25 19:36:10 2017 -0400

    Remove unused .gitmodules (babel#457)

commit a750684
Author: Andres Suarez <zertosh@gmail.com>
Date:   Sat Mar 25 19:32:05 2017 -0400

    Use dedent for unpadding (babel#456)

commit cdb92fe
Merge: 21dac73 ec14787
Author: Henry Zhu <hi@henryzoo.com>
Date:   Sat Mar 25 19:15:23 2017 -0400

    Merge pull request babel#455 from babel/babylon-to-espree-tidy

    Tidy up babylon-to-espree

commit ec14787
Author: Andres Suarez <zertosh@gmail.com>
Date:   Sat Mar 25 18:03:17 2017 -0400

    Enable strict mode in all of babylon-to-espree

commit 6c5beec
Author: Andres Suarez <zertosh@gmail.com>
Date:   Sat Mar 25 18:01:13 2017 -0400

    Move ast convert steps to babylon-to-espree

commit d2ce789
Author: Andres Suarez <zertosh@gmail.com>
Date:   Sat Mar 25 17:42:51 2017 -0400

    Use for-loop for template literal conversion

commit 539af05
Author: Andres Suarez <zertosh@gmail.com>
Date:   Sat Mar 25 17:36:20 2017 -0400

    Only iterate over tokens once

commit 06c3a31
Author: Andres Suarez <zertosh@gmail.com>
Date:   Sat Mar 25 17:28:01 2017 -0400

    Inline fixDirectives and use for-loop

commit 5d32ad0
Author: Andres Suarez <zertosh@gmail.com>
Date:   Sat Mar 25 17:07:41 2017 -0400

    Consolidate versions of "convertComments"

commit 2541fc9
Author: Andres Suarez <zertosh@gmail.com>
Date:   Sat Mar 25 00:18:57 2017 -0400

    toAst pass "source" in state instead of keeping in scope

commit 21dac73
Author: Andres Suarez <zertosh@gmail.com>
Date:   Thu Mar 23 15:46:48 2017 -0400

    Add type parameter scope tests (babel#454)

commit 3cda62e
Author: Henry Zhu <hi@henryzoo.com>
Date:   Thu Mar 23 14:03:23 2017 -0400

    7.2.1

commit 5626de1
Author: Andres Suarez <zertosh@gmail.com>
Date:   Thu Mar 23 14:02:24 2017 -0400

    Remove left over eslint 2 estraverse code (babel#452)

    This was missed in babel#361

commit b5fb53b
Author: Andres Suarez <zertosh@gmail.com>
Date:   Thu Mar 23 12:49:19 2017 -0400

    Fix type param and interface declaration scoping (babel#449)

commit f1cee0f
Author: Andres Suarez <zertosh@gmail.com>
Date:   Wed Mar 22 22:35:31 2017 -0400

    Remove lodash dependency (babel#450)

commit eb05812
Author: Andres Suarez <zertosh@gmail.com>
Date:   Wed Mar 22 22:34:13 2017 -0400

    Format non-regression errors for legibility (babel#451)

commit 7972a05
Author: Luís Couto <hello@luiscouto.pt>
Date:   Tue Mar 21 00:11:30 2017 +0000

    Update README.md with codeFrame option (babel#448)

commit 4db4db5
Author: Henry Zhu <hi@henryzoo.com>
Date:   Mon Mar 20 17:53:26 2017 -0400

    7.2.0

commit 4499412
Author: wtgtybhertgeghgtwtg <wtgtybhertgeghgtwtg@gmail.com>
Date:   Mon Mar 20 14:50:09 2017 -0700

    Use `lodash` instead of `lodash.pickby`. (babel#435)

commit a2c3b30
Author: Alex Rattray <rattray.alex@gmail.com>
Date:   Mon Mar 20 14:46:07 2017 -0700

    [flow] Process polymorphic type bounds on functions (babel#444)

commit 515adef
Author: Luís Couto <hello@luiscouto.pt>
Date:   Mon Mar 20 21:45:11 2017 +0000

    Add option to disable code frame. (babel#446)

    * Add option to disable code hightlight.

    * Rename codeHighlight with codeFrame

    * Add codeFrame tests

    * Remove colors from test assertions

commit ce66e73
Merge: bdeb86f b49ab20
Author: Henry Zhu <hi@henryzoo.com>
Date:   Mon Mar 20 11:44:33 2017 -0400

    Merge pull request babel#447 from kaicataldo/clean-up-eslint

    Chore: Clean up and upgrades

commit b49ab20
Author: Kai Cataldo <kaicataldo@gmail.com>
Date:   Mon Mar 20 10:33:14 2017 -0400

    Updates ESLint version/remove unnecessary config

commit 702d6b8
Author: Kai Cataldo <kaicataldo@gmail.com>
Date:   Mon Mar 20 10:27:28 2017 -0400

    Remove broken ESLint tests

commit 6b4c4ca
Author: Kai Cataldo <kaicataldo@gmail.com>
Date:   Sat Mar 11 22:15:47 2017 -0500

    Upgrade outdated dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement linter
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
1 participant
@wcjohnson