Cmake python #105
Cmake python #105
Conversation
CMake 3.12 adds FindPython which replaces FindPythonInterp and FindPythonLibs and updates corresponding result variables. As of CMake 3.27 you must set CMP0148 to OLD to retain this behavior. This PR updates CMake code to the new behavior while retaining support for older CMake versions. Signed-off-by: Jean-Francois Panisset <panisset@gmail.com>
Signed-off-by: Jean-Francois Panisset <panisset@gmail.com>
CMakeLists.txt
Outdated
| else() | ||
| find_package(PythonInterp REQUIRED) | ||
| find_package(PythonLibs REQUIRED) | ||
| endif() |
There was a problem hiding this comment.
Thanks for making this backwards-compatible. I just noticed that we're already using cmake_minimum_required(VERSION 3.15.0) so we already specify a minimum cmake version of 3.15.
That suggests that we can drop the backwards compatibility. Please adjust these changes so that they only support the newer FindPython module.
There is one small tweak we'll need above ~ please use find_package(Python REQUIRED COMPONENTS ...) so that cmake will error-out during the configure step when python is not available. It's currently missing the REQUIRED option.
There was a problem hiding this comment.
Changes pushed to branch as requested, thank you for the review.
For context, I'm converting the build of partio to a Conan package for the aswf-docker project, which is when I ran into complaints from recent CMake version about pre-FindPython usage.
As per review, partio specifies CMake 3.15 or newer so backwards compatibility is not required. Also build should fail if FindPython doesn't find Python. Signed-off-by: Jean-Francois Panisset <panisset@gmail.com>
|
Thanks! I made some tiny tweaks on top of this, but it's all good now. |
CMake 3.12 adds FindPython which replaces FindPythonInterp and FindPythonLibs and updates corresponding result variables. As of CMake 3.27 you must set CMP0148 to OLD to retain this behavior. This PR updates CMake code to the new behavior while retaining support for older CMake versions.