Fix cmake #30
Merged
Fix cmake #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check whether CMAKE_INSTALL_PREFIX is defined before overwriting its value. This allows users to specify an alternate install prefix during the `cmake` invocation. Signed-off-by: David Aguilar <davvid@gmail.com>
Use ${DOXYGEN_EXECUTRABLE} instead of hard-coding /usr/bin/doxygen.
Signed-off-by: David Aguilar <davvid@gmail.com>
We were referring to a build directory that does not exist when building out-of-tree. For example: mkdir build cd build cmake .. make make DESTDIR=$PWD/DESTDIR install The `install` step will fail because build/src/py/partio.py does not exist. Remove the src/ subdirectory in the path so that the file beneath build/ is found. Signed-off-by: David Aguilar <davvid@gmail.com>
|
Wondering if this request got spotted or not~ |
|
Anyone? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those 3 commits about cmake was done by davvid/partio and I have double checked to make sure it works well under Linux and Mac OS X. I like to suggest merge his work. Furthermore, that can make sure mxcl/homebrew will be happy to see that.