Partio::clone() implementation and tests #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the same libdir as parito itself by default while allowing the user to override the value if necessary.
Use cut instead of sed with better fallback examples.
clone() does a full copy of both FixedAttributes and particle data. If only the FixedAttributes are wanted, the caller can pass particles=false to avoid copying particles.
| size_t size = Partio::TypeSize(dstFixedAttr.type) * dstFixedAttr.count; | ||
| std::memcpy(dst, src, size); | ||
| } | ||
| if (!particles) { |
There was a problem hiding this comment.
I prefer forward logic so
if(particles){ big block }
return p
(also gives single exit)
aselle
added a commit
that referenced
this pull request
Aug 28, 2015
Partio::clone() implementation and tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Partio::clone() and add unit tests demonstrating its usage.