More cmake fixes #71
More cmake fixes #71
Conversation
|
@SoapGentoo Your partconvert patch is better than mine. :) I'm currently trying to bump a lot of packages, and can add this one to Partio. Thanks. |
* partconv is the name of a program used by Crystal Space
See also:
https://bugs.gentoo.org/631834
* Only enable C++ Speeds up the configure process
* SoapGentoo/more-cmake-fixes: More CMake modernizations Use GNUInstallDirs everywhere Rename partconv to partconvert to avoid file collisions Signed-off-by: David Aguilar <davvid@gmail.com>
|
Thanks for renaming the executable. In the future if we hit conflicts we could call them e.g. |
| SET( ${PROJECT_NAME}_MINOR_VERSION 1 ) | ||
| SET( ${PROJECT_NAME}_PATCH_LEVEL 0 ) | ||
| include(GNUInstallDirs) | ||
| PROJECT( partio LANGUAGES CXX VERSION 0.1.1 ) |
There was a problem hiding this comment.
@davvid I bumped this to 0.1.1 for all the fixes. Could you please tag a new release so we can add it in Gentoo and remove all the patches?
There was a problem hiding this comment.
Hi @SoapGentoo I just tagged partio v1.5.0. This includes a merge of our internal changes so that we're 1:1 identical with the open source version now. Let me know if I missed anything and we can fix and tag a new version as needed.
Hi @davvid
some more small fixes to polish up the CMake.
the
partconvbinary collides with a game that uses the same name, can we rename this to avoid the collision?