Fix link against specific python version on macOS #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partio currently has explicit Python version links. This makes it hard to upgrade the hombres formula at this point (Homebrew/homebrew-core#38921). The patch should fix it. [Here is the explanation](http://blog.tim-smith.us/2015/09/python-extension-modules-os-x/) about why it would be good if you could use the -undefined dynamic_lookup flag while linking under OS X:
davvid
requested changes
Apr 18, 2019
| @@ -52,6 +52,9 @@ IF(WIN32) | |||
| ELSE(WIN32) | |||
| ADD_COMPILE_OPTIONS (-Wextra -Wno-unused-parameter) | |||
| ENDIF(WIN32) | |||
| IF(${CMAKE_SYSTEM_NAME} MATCHES "Darwin") | |||
| set (CMAKE_SHARED_LINKER_FLAGS "-undefined dynamic_lookup") | |||
| ENDIF() | |||
There was a problem hiding this comment.
Thanks for the sug. Would it be more idiomatic to write this as:
IF(APPLE)
...
ENDIF()
?
Looks good otherwise. If that construct works for you too then please update it and we'll get this merged in.
There was a problem hiding this comment.
thanks for the hint. Made the change as requested.
davvid
added a commit
that referenced
this pull request
Apr 19, 2019
* DennisOSRM/patch-1: Update CMakeLists.txt Fix link against specific python version on macOS Signed-off-by: David Aguilar <david.aguilar@disneyanimation.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partio currently has explicit Python version links. This makes it hard to upgrade the hombres formula at this point (Homebrew/homebrew-core#38921). The patch should fix it.
Here is the explanation about why it would be good if you could use the -undefined dynamic_lookup flag while linking under OS X: