Repository navigation
Provider request: Bitvavo (direct exchange connector) #4885
lukaschoebel
started this conversation in
Feature Requests
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Describe the feature
A native Bitvavo provider that connects straight to the Bitvavo API, built like the existing Kraken, Binance and Coinbase providers.
Bitvavo documents its REST API at https://docs.bitvavo.com/
Why is this feature important?
Today Bitvavo only reaches Sure through CoinStats, with "Link Exchange API" in the CoinStats dialog. On the CoinStats free plan that link fails with this error.
So a Bitvavo user has to pay for a CoinStats plan to sync a single exchange. A direct provider removes that dependency. It also keeps the exchange credentials between Sure and Bitvavo only, where today Sure forwards them to CoinStats.
The CoinStats link dialog already names Bitvavo as its first example, so other users are likely to hit the same limit.
Additional context, screenshots, and relevant links
Setup: Sure 0.7.6, self-hosted with Docker Compose (web and worker), CoinStats free API plan. The CoinStats API key is valid. The connection is configured and syncs without errors.
What I tried before asking:
COINSTATS_MIN_REQUEST_INTERVAL=1.5on web and worker to slow down the rps. The error stays.One thing I noticed in the code.
Provider::RateLimitable#throttle_requeststores@last_request_timeon the provider instance, and the CoinStats controller and linker each create their ownProvider::Coinstats. The default spacing of 0.5 seconds matches the free plan's 2 requests per second, but nothing enforces it across instances or between web and worker. Slowing the requests down did not fix the link, so I don't think this is the whole cause. I can open a separate bug report for it if that helps.I am willing to look into this and open a PR which orients itself on the Kraken provider. Would you accept a Bitvavo provider, and should anything differ from the existing exchange connectors?
All reactions