Functional tests for WP-CLI commands

[swissspidy]

Description

This PR sets up the necessary infrastructure for running Behat tests for the built-in WP-CLI commands.

So far this includes only a test for wp traduttore info, but not yet tests for the other commands.

For these, I think we need to figure out how to create a bunch of GlotPress projects with meta data etc. when running the tests. Ideally there would be some proper WP-CLI commands for that, but GlotPress doesn't currently provide any to do such CRUD operations. Perhaps we have to contribute these upstream...

That would make writing these tests way easier. An alternative was mentioned below:

You could just import a SQL dump or create a PHP file which is executed once and creates all the things.

Fixes #21.

How has this been tested?

By writing tests :-)

Types of changes
New functional tests for WP-CLI commands.

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code has proper inline documentation.

[swissspidy]

With all the Behat stuff being in a separate package it's not that straightforward to do so. Plus you'd want to test things like wp traduttore project build --all without any projects around and other edge case scenarios.

Also it would benefit everyone else using GlotPress and WP-CLI 🙂

[ocean90]

Is the code coverage working? Wondering since there's no change on https://app.codecov.io/gh/wearerequired/traduttore/compare/124.

[szepeviktor]

Is the code coverage working?

The upload step in CI says

Reports have been successfully queued for processing at codecov.io/github/wearerequired/traduttore/commit/0a906c10bb9465558fc77a0cbadac3dfcb8f7706

And Codecov knows about our latest commit
https://github.com/wearerequired/traduttore/pull/124/checks?check_run_id=3027581945

[swissspidy]

Is the code coverage working?

The upload step in CI says

Reports have been successfully queued for processing at codecov.io/github/wearerequired/traduttore/commit/0a906c10bb9465558fc77a0cbadac3dfcb8f7706

And Codecov knows about our latest commit
#124 (checks)

Plus, locally the clover files are generated just fine and I can see the code coverage for InfoCommand and the like as expected.

There must be something wrong with the paths in there or something.

I'll try to compare the output with the one from PHPUnit.

[swissspidy]

So strange 😕

Setting pcov.directory and pcov.exclude did definitely help and the coverage files now look more or less the same as when using Xdebug.

The only big difference I found between the coverage file from PHPUnit and the one from Behat is the namespace.

The former has namespace="Required\Traduttore" and <package name="Required\Traduttore"> everywhere, the one from Behat has namespace="global".

[ocean90]

fwiw: @schlessera did disable the codecov upload in ampproject/amp-wp@07a844f. The comment for the reason isn't clear to me though.

[swissspidy]

fwiw: @schlessera did disable the codecov upload in ampproject/amp-wp@07a844f. The comment for the reason isn't clear to me though.

Interesting! I don't see why merging wouldn't work though, as we usually merge multiple reports in the web-stories-wp repo and it works just fine there.

[ocean90]

Let's merge this and see if we can fix the coverage upload in a follow-up PR.