Add route information to request.

[Christopher-Bui]

Feature for #82 and subsumes #93

[weavejester]

assoc-route-info would be a name more in keeping with the other functions in the namespace.

[weavejester]

This is a private function, so the docstring can be removed.

[weavejester]

Use (str path) rather than (:source path).

[weavejester]

Also, you can't use :request-method, as it doesn't necessarily reflect the route method. Instead, pass method as an argument in.

[weavejester]

It would be better to pre-calculate the route info, e.g.

(let [route-info [(or method :any) (str path)]] ...)

[Christopher-Bui]

Couple of questions:

Is the reason you say to precompute the route info to decouple the add-route-information function from needing to know about the stuff? Secondly, after doing that and renaming the add-route-information to assoc-route-info, it doesn't seem like there's much added to having that private fn so I removed it. Is that cool?

Thanks for your feedback!

[weavejester]

Precomputation just avoids creating a new vector each time. So currently you've written:

 (defn make-route [method path handler]
   (if-method method
     (if-route path
       (wrap-route-middleware
         (fn [request]
           (let [route-info [(or method :any) (str path)]]
             (response/render (handler (assoc request :route route-info))
                              request)))))))

But we can take the route-info binding out to the top level instead:

 (defn make-route [method path handler]
   (let [route-info [(or method :any) (str path)]]
     (if-method method
       (if-route path
         (wrap-route-middleware
           (fn [request]
             (let [request (assoc request :route route-info)]
               (response/render (handler request) request))))))))

Now the route-info vector is only calculated once, when the route is first constructed. Even though building the route-info isn't likely to take long, if we can save a little time and memory just by moving the let binding around, we should do it.

[weavejester]

Removing the private function was the right call, I think. Could you also add a test to check that ANY routes work okay as well? They're a special case, so we should ensure they work.

[Christopher-Bui]

Ping @weavejester

[weavejester]

Thanks for the ping. This should be okay, but I think that :compojure/route might be a better key, as :route is a little generic. Make that change and I'll merge :)

[Christopher-Bui]

@weavejester good?

[weavejester]

That looks fine. Now you just need to squash your commits.

[Christopher-Bui]

Squashed.

[weavejester]

Thanks! Can you remove the ending "." from the commit summary? Then I'll merge.

[Christopher-Bui]

Done!