-
Notifications
You must be signed in to change notification settings - Fork 5
bootstrapping secrets from management cluster to leaf clusters #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
package v1alpha2 | ||
|
||
import ( | ||
v1 "k8s.io/api/core/v1" | ||
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
) | ||
|
||
// SecretSyncSpec | ||
type SecretSyncSpec struct { | ||
// Label selector for Clusters. The Clusters that are | ||
// selected by this will be the ones affected by this SecretSync. | ||
// It must match the Cluster labels. This field is immutable. | ||
// Label selector cannot be empty. | ||
ClusterSelector metav1.LabelSelector `json:"clusterSelector"` | ||
// SecretRef specifies the Secret to be bootstrapped to the matched clusters | ||
// Secret must be in the same namespace of the SecretSync object | ||
SecretRef v1.LocalObjectReference `json:"secretRef"` | ||
// TargetNamespace specifies the namespace which the secret should be bootstrapped in | ||
// The default value is the namespace of the referenced secret | ||
//+optional | ||
TargetNamespace string `json:"targetNamespace,omitempty"` | ||
} | ||
|
||
// SecretSyncStatus secretsync object status | ||
type SecretSyncStatus struct { | ||
// SecretVersions a map contains the ResourceVersion of the secret of each cluster | ||
// Cluster name is the key and secret's ResourceVersion is the value | ||
SecretVersions map[string]string `json:"versions"` | ||
} | ||
|
||
// SetClusterSecretVersion sets the latest secret version of the given cluster | ||
func (s *SecretSyncStatus) SetClusterSecretVersion(cluster, version string) { | ||
if s.SecretVersions == nil { | ||
s.SecretVersions = make(map[string]string) | ||
} | ||
s.SecretVersions[cluster] = version | ||
} | ||
|
||
// GetClusterSecretVersion returns secret's ResourceVersion of the given cluster | ||
func (s *SecretSyncStatus) GetClusterSecretVersion(cluster string) string { | ||
return s.SecretVersions[cluster] | ||
} | ||
|
||
//+kubebuilder:object:root=true | ||
//+kubebuilder:subresource:status | ||
//+kubebuilder:storageversion | ||
//+kubebuilder:scope:namespaced | ||
|
||
type SecretSync struct { | ||
metav1.TypeMeta `json:",inline"` | ||
metav1.ObjectMeta `json:"metadata,omitempty"` | ||
Spec SecretSyncSpec `json:"spec,omitempty"` | ||
Status SecretSyncStatus `json:"status,omitempty"` | ||
} | ||
|
||
//+kubebuilder:object:root=true | ||
|
||
type SecretSyncList struct { | ||
metav1.TypeMeta `json:",inline"` | ||
metav1.ListMeta `json:"metadata,omitempty"` | ||
Items []SecretSync `json:"items"` | ||
} | ||
|
||
func init() { | ||
SchemeBuilder.Register(&SecretSync{}, &SecretSyncList{}) | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,120 @@ | ||
--- | ||
apiVersion: apiextensions.k8s.io/v1 | ||
kind: CustomResourceDefinition | ||
metadata: | ||
annotations: | ||
controller-gen.kubebuilder.io/version: v0.9.2 | ||
creationTimestamp: null | ||
name: secretsyncs.capi.weave.works | ||
spec: | ||
group: capi.weave.works | ||
names: | ||
kind: SecretSync | ||
listKind: SecretSyncList | ||
plural: secretsyncs | ||
singular: secretsync | ||
scope: Namespaced | ||
versions: | ||
- name: v1alpha2 | ||
schema: | ||
openAPIV3Schema: | ||
properties: | ||
apiVersion: | ||
description: 'APIVersion defines the versioned schema of this representation | ||
of an object. Servers should convert recognized schemas to the latest | ||
internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources' | ||
type: string | ||
kind: | ||
description: 'Kind is a string value representing the REST resource this | ||
object represents. Servers may infer this from the endpoint the client | ||
submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds' | ||
type: string | ||
metadata: | ||
type: object | ||
spec: | ||
description: SecretSyncSpec | ||
properties: | ||
clusterSelector: | ||
description: ClusterSelector specifies the label selector to match | ||
clusters with | ||
properties: | ||
matchExpressions: | ||
description: matchExpressions is a list of label selector requirements. | ||
The requirements are ANDed. | ||
items: | ||
description: A label selector requirement is a selector that | ||
contains values, a key, and an operator that relates the key | ||
and values. | ||
properties: | ||
key: | ||
description: key is the label key that the selector applies | ||
to. | ||
type: string | ||
operator: | ||
description: operator represents a key's relationship to | ||
a set of values. Valid operators are In, NotIn, Exists | ||
and DoesNotExist. | ||
type: string | ||
values: | ||
description: values is an array of string values. If the | ||
operator is In or NotIn, the values array must be non-empty. | ||
If the operator is Exists or DoesNotExist, the values | ||
array must be empty. This array is replaced during a strategic | ||
merge patch. | ||
items: | ||
type: string | ||
type: array | ||
required: | ||
- key | ||
- operator | ||
type: object | ||
type: array | ||
matchLabels: | ||
additionalProperties: | ||
type: string | ||
description: matchLabels is a map of {key,value} pairs. A single | ||
{key,value} in the matchLabels map is equivalent to an element | ||
of matchExpressions, whose key field is "key", the operator | ||
is "In", and the values array contains only "value". The requirements | ||
are ANDed. | ||
type: object | ||
type: object | ||
x-kubernetes-map-type: atomic | ||
secretRef: | ||
description: SecretRef specifies the Secret to be bootstrapped to | ||
the matched clusters Secret must be in the same namespace of the | ||
SecretSync object | ||
properties: | ||
name: | ||
description: 'Name of the referent. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names | ||
TODO: Add other useful fields. apiVersion, kind, uid?' | ||
type: string | ||
type: object | ||
x-kubernetes-map-type: atomic | ||
targetNamespace: | ||
description: TargetNamespace specifies the namespace which the secret | ||
should be bootstrapped in The default value is the namespace of | ||
the referenced secret | ||
type: string | ||
required: | ||
- clusterSelector | ||
- secretRef | ||
type: object | ||
status: | ||
description: SecretSyncStatus secretsync object status | ||
properties: | ||
versions: | ||
additionalProperties: | ||
type: string | ||
description: SecretVersions a map contains the ResourceVersion of | ||
the secret of each cluster Cluster name is the key and secret's | ||
ResourceVersion is the value | ||
type: object | ||
required: | ||
- versions | ||
type: object | ||
type: object | ||
served: true | ||
storage: true | ||
subresources: | ||
status: {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we document these?
This has a direct impact on the output from the CRD (and the documentation generated from the CRD).
See https://github.com/fluxcd/source-controller/blob/main/api/v1beta2/gitrepository_types.go for a great example.