Remove all traces of v1alpha2 #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes v1alpha2, we'll take a different approach.
If the original annotation is on a Cluster, then it will be skipped the old annotation was "capi.weave.works/bootstrapped" Otherwise, we only store the applied CBCs on the new "capi.weave.works/bootstrap-configs" annotation, which is used to prevent reapplying already applied configs.
foot
approved these changes
Feb 17, 2023
| description: Label selector for Clusters. The Clusters that are selected | ||
| by this will be the ones affected by this SecretSync. It must match | ||
| the Cluster labels. This field is immutable. Label selector cannot | ||
| be empty. |
There was a problem hiding this comment.
👍 , updated CRDs? Maybe we should add some dev-guidelines in README.md
There was a problem hiding this comment.
Yeah, I suspect a task in an action to make manifests generate and then check to see if there's a git diff would solve it?
| "testing" | ||
|
|
||
| gitopsv1alpha1 "github.com/weaveworks/cluster-controller/api/v1alpha1" | ||
| clustersv1 "github.com/weaveworks/cluster-controller/api/v1alpha1" |
Co-authored-by: Simon <footless@gmail.com>
Prevent rebootstrapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes v1alpha2, we'll take a different approach.