Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend SeriesOverride #434

Merged
merged 9 commits into from Nov 29, 2021
Merged

Conversation

milkpirate
Copy link
Contributor

@milkpirate milkpirate commented Nov 26, 2021

What does this do?

Extends the SeriesOverride options.

Why is it a good idea?

Especially add fillBelowTo and fill to SeriesOverride.

Copy link
Collaborator

@JamesGibo JamesGibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for extending this class

@JamesGibo JamesGibo merged commit c533594 into weaveworks:main Nov 29, 2021
@milkpirate
Copy link
Contributor Author

Pretty great that you are so responsive! I never have to wait long to get the features in need in mainline :)

STandon-3 pushed a commit to bbc/grafanalib that referenced this pull request Dec 1, 2021
* add new options and validators

* comply lint

* readd random

* add tests

* upd chglg

* missing .

* add fill

* upd chglg

Co-authored-by: Paul Schroeder <paul.schroeder@localhost>
STandon-3 pushed a commit to bbc/grafanalib that referenced this pull request Dec 1, 2021
* add new options and validators

* comply lint

* readd random

* add tests

* upd chglg

* missing .

* add fill

* upd chglg

Co-authored-by: Paul Schroeder <paul.schroeder@localhost>
JamesGibo added a commit that referenced this pull request Dec 3, 2021
* Extend SeriesOverride (#434)

* add new options and validators

* comply lint

* readd random

* add tests

* upd chglg

* missing .

* add fill

* upd chglg

Co-authored-by: Paul Schroeder <paul.schroeder@localhost>

* Bump sphinx from 4.3.0 to 4.3.1

Bumps [sphinx](https://github.com/sphinx-doc/sphinx) from 4.3.0 to 4.3.1.
- [Release notes](https://github.com/sphinx-doc/sphinx/releases)
- [Changelog](https://github.com/sphinx-doc/sphinx/blob/4.x/CHANGES)
- [Commits](sphinx-doc/sphinx@v4.3.0...v4.3.1)

---
updated-dependencies:
- dependency-name: sphinx
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Adding percentage option for Threshold class

* Deep update overrides and switch gauge panel to fieldConfig.defualts

* Remove threshold from statetimeline panel

Co-authored-by: milkpirate <milkpirate@users.noreply.github.com>
Co-authored-by: Paul Schroeder <paul.schroeder@localhost>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: James Gibson <james.gibson@bbc.co.uk>
@milkpirate milkpirate deleted the upd-SeriesOverrides branch February 6, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants