Update faq.md - fix read-only mode gotcha #3836
Conversation
kingdonb
requested review from
bboreham,
fbarl,
qiell and
satyamz
as code owners
|
I think the following section has a similar error. The dashes are proper ASCII hyphen-minus, but they are single dashes and should be double dashes. Pushing up another commit to address this while I'm here. |
kingdonb
force-pushed
the
no-controls-faq
branch
from
a0258ed to
ea95a37
Compare
There was a problem hiding this comment.
Thanks; it turns out single-hyphen arguments are valid, though I'm ok to change for consistency.
https://golang.org/pkg/flag/#hdr-Command_line_flag_syntax
site/faq.md
Outdated
| ## Disabling Scope Write Access | ||
|
|
||
| Can be done by using the `probe.no-controls` option and set it to false for the scope agents. This can be done in the scope deployment manifest under the `weave-scope-agent`'s argument section with `—probe.no-controls=true`. | ||
| Can be done by using the `probe.no-controls` option and set it to false for the scope agents. This can be done in the scope daemonset manifest under the `weave-scope-agent`'s argument section with `--probe.no-controls=true`. |
There was a problem hiding this comment.
Nowadays we have both a Deployment (which handles Kubernetes data for the whole cluster) and a DaemonSet (which handles everything else on a per-host basis).
There was a problem hiding this comment.
Ah. Does it need to be passed on to both then? I only noticed one (my cluster is also a single node)
My update went to the daemonset and it seemed to do the trick
Edit: I read your comment in the associated issue. I'll test again and update the PR later this morning to say daemonset and deployment. 👍
There was a problem hiding this comment.
I read once more carefully and it looks like there was another error in this paragraph. I think it reads correctly now.
|
That makes sense. I was just going by what I saw was already in use in existing args in the daemonset. |
* use double dashes for consistency * fixup - says "set it to false", should be "true" * fixup - the deployment and the daemonset both need this setting Signed-off-by: Kingdon Barrett <kingdon@weave.works>
kingdonb
force-pushed
the
no-controls-faq
branch
from
ea95a37 to
05596a9
Compare
|
This was confirmed in #3835 👍 |
Someone's text editor has made this
U+2014 : EM DASHinstead of a double-dash. Closes #3835