Code duplication: cluster/machines manifest location

[mflendrich]

The chunk of code that tells whether the cluster/machines.yaml files come from a local FS or from a git repo to be cloned is identical in several places in our code. This is not good, because these implementations will diverge and cause extra maintenance burden.

[mflendrich]

Commit d2bae27 marks the places where code repetition happens.

[bensooraj]

Can I take this up?

[mflendrich]

Can I take this up?

Sure! Thanks for your will to help.

[bensooraj]

I am facing some error trying install the dependencies:

$ go get all -v
go: github.com/weaveworks/footloose@v0.0.0-20190829132911-efbcbb7a6390: invalid pseudo-version: does not match version-control timestamp (2019-09-03T13:20:36Z)

Unable to identify what's causing the issue.

Also, as part of the solution, following are my thoughts:

1. Move the duplicate functions out to pkg/utilities/file.go
2. Have on function each GetClusterManifestPath() and GetMachinesManifestPath() to fetch the cluster's and the machine's manifest paths respectively.

Please do let me know if I am thinking in the right direction.