-
Notifications
You must be signed in to change notification settings - Fork 21
Open
Labels
Description
Should we validate the page size to be >=1?
Originally posted by @salvatore-campagna-weaviate in #399 (comment)
For the large part, client6
relies on server-side validation for request parameters to avoid duplicating the logic. Similarly, validating things like connection parameters is often redundant, since our HTTP and gRPC client libraries will catch and report that.
There's a third type of inputs, specific to the client's behavior, which we should validate.
In the example above, page size (while validated server-side) may be used to pre-allocate an array or similar and must, in this case, be >= 1.