Skip to content

Use ! to simplify test logic #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2025
Merged

Use ! to simplify test logic #354

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 21 additions & 36 deletions src/collections/vectors/journey.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,7 @@
/* eslint-disable @typescript-eslint/no-non-null-assertion */
/* eslint-disable @typescript-eslint/no-non-null-asserted-optional-chain */
import { requireAtLeast } from '../../../test/version.js';
import weaviate, {
VectorIndexConfigHNSW,
WeaviateClient,
WeaviateField,
WeaviateGenericObject,
} from '../../index.js';
import weaviate, { VectorIndexConfigHNSW, WeaviateClient } from '../../index.js';
import { Collection } from '../collection/index.js';
import { MultiVectorType, SingleVectorType } from '../query/types.js';

Expand Down Expand Up @@ -78,40 +73,30 @@ requireAtLeast(1, 29, 0).describe(

it('should be able to get the inserted object with its vectors stated implicitly', async () => {
const obj = await collection.query.fetchObjectById(id1, { includeVector: true });
const assert = (obj: any): obj is WeaviateGenericObject<Record<string, WeaviateField>, MyVectors> => {
expect(obj).not.toBeNull();
return true;
};
if (assert(obj)) {
singleVector = obj.vectors.regular;
multiVector = obj.vectors.colbert;
expect(obj.uuid).toBe(id1);
expect(obj.vectors).toBeDefined();
expect(obj.vectors.regular).toEqual([1, 2, 3, 4]);
expect(obj.vectors.colbert).toEqual([
[1, 2],
[3, 4],
]);
}
expect(obj).not.toBeNull();
singleVector = obj!.vectors.regular;
multiVector = obj!.vectors.colbert;
expect(obj!.uuid).toBe(id1);
expect(obj!.vectors).toBeDefined();
expect(obj!.vectors.regular).toEqual([1, 2, 3, 4]);
expect(obj!.vectors.colbert).toEqual([
[1, 2],
[3, 4],
]);
});

it('should be able to get the inserted object with its vectors stated explicitly', async () => {
const obj = await collection.query.fetchObjectById(id1, { includeVector: ['regular', 'colbert'] });
const assert = (obj: any): obj is WeaviateGenericObject<Record<string, WeaviateField>, MyVectors> => {
expect(obj).not.toBeNull();
return true;
};
if (assert(obj)) {
singleVector = obj.vectors.regular;
multiVector = obj.vectors.colbert;
expect(obj.uuid).toBe(id1);
expect(obj.vectors).toBeDefined();
expect(obj.vectors.regular).toEqual([1, 2, 3, 4]);
expect(obj.vectors.colbert).toEqual([
[1, 2],
[3, 4],
]);
}
expect(obj).not.toBeNull();
singleVector = obj!.vectors.regular;
multiVector = obj!.vectors.colbert;
expect(obj!.uuid).toBe(id1);
expect(obj!.vectors).toBeDefined();
expect(obj!.vectors.regular).toEqual([1, 2, 3, 4]);
expect(obj!.vectors.colbert).toEqual([
[1, 2],
[3, 4],
]);
});

it('should be able to get the inserted object with one of its vectors', async () => {
Expand Down